bugfix: shouldComponentUpdate #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're here, the first argument of |
Member
|
Yes @nicgordon is right. https://reactjs.org/docs/react-component.html#shouldcomponentupdate Thank you to both of you. I really appreciate the help and love the community around reacts for being so kind. I will test It soonish and also adjust the props. 🙏🏼 |
The shouldComponentUpdate API defines that the arguments are nextProps and nextState. So we replace prevProps with nextProps.
markusguenther
approved these changes
Dec 5, 2018
Member
markusguenther
left a comment
There was a problem hiding this comment.
Thanks for reporting and fixing @ovaldi
Member
|
🎉 This PR is included in version 3.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47