Atrules update - Purge @font-face, Small refactor - #48
Merged
Conversation
…walk, Add options and tests for font-face
Ffloriel
self-requested a review
January 29, 2018 21:40
Ffloriel
requested changes
Jan 29, 2018
Ffloriel
left a comment
Member
There was a problem hiding this comment.
Great PR! Thanks a lot.
Looks good to me. I just think it is better to keep the options in camelCase.
Collaborator
Author
|
Sure, did the changes |
Ffloriel
approved these changes
Jan 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Only use one .walk to do everything,
evaluateRuleand if the rule is not removed then record the relevant declarations - line 309 to 322after that there are two simple for loops that remove the keyframes and the font-faces, line 150 and 164
There might be a bug if someone uses the css
font: 'My Fam' 20pxbecause I only check forfont-family: 'My Fam'because im not sure how to handle it if there are quotes around the name.also #41 is fixed
Types of changes
Checklist