Skip to content

upgrade ember-cli-htmlbars to 1.0.1 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsing80
Copy link

@tsing80 tsing80 commented Nov 10, 2015

Current version will break app build on windows once broccolijs/broccoli-merge-trees#31 is merged
Upgrade ember-cli-htmlbars to latest version fixed the issue

cc @stefanpenner

@jbescoyez
Copy link

jbescoyez commented Jan 3, 2017

@Gaurav0 Any chance to see this merged?

It triggers deprecation warning with the last versions of Ember:

DEPRECATION: Overriding init without calling this._super is deprecated. Please call `this._super.init && this._super.init.apply(this, arguments);` addon: `ember-cli-htmlbars`
    at Function.Addon.lookup (.../node_modules/ember-cli/lib/models/addon.js:1005:27)

@jaaksarv
Copy link

jaaksarv commented Feb 3, 2017

Can you please merge this? I also have this problem after upgrading Ember to latest version.

@Gaurav0
Copy link
Owner

Gaurav0 commented Feb 3, 2017

No. Conflicts must be resolved and tests must pass.

@jaaksarv
Copy link

jaaksarv commented Feb 6, 2017

@tsing80 can you fix it please?

@aars
Copy link

aars commented Mar 15, 2017

@Gaurav0 You mention you want to deprecate this package in this PR, #20

Are you? This PR no longer makes sense since htmlbars 1.0.8 is already referenced in the package.json, but no release is made. Is there a release coming?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants