Skip to content

fix #18: nested props are ignored if the first one is undefined #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2022
Merged

fix #18: nested props are ignored if the first one is undefined #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ module.exports = (UserProps) => {

// warn if props won't resolve from plugin
if (!value) {
return
continue
}

// create and append prop to :root
Expand Down
16 changes: 16 additions & 0 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,22 @@ a {
)
})

it('Can jit a single, undefined prop that has fallbacks and nested props', async () => {
await run(
`a {
color: var(--orange, var(--pink), hotpink);
}`,
`:root {
--pink: #ffc0cb;
}
a {
color: var(--orange, var(--pink), hotpink);
}`,
MockProps
)
})


it('Can jit a single prop with spaces that has fallbacks and nested props', async () => {
await run(
`a {
Expand Down