Skip to content

enhancement/plugin-guidelines #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 14, 2023
Merged

enhancement/plugin-guidelines #33

merged 9 commits into from
Feb 14, 2023

Conversation

mod3x
Copy link
Contributor

@mod3x mod3x commented Feb 14, 2023

Hi. This PR introduces some minor changes in the code, such as:

  • Removing unused async in Once visitor.
  • Basic type checking through JSDoc type import.
  • Faster media at-rule visitor (according to Evil Martians migration guide).
  • Removing PostCSS import (Evil Martians' recommendation again).

Thank you.

argyleink
argyleink approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@argyleink argyleink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rad, looks good, thanks for bringing those updates here

@argyleink argyleink merged commit 0807524 into GoogleChromeLabs:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argyleink argyleink argyleink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mod3x @argyleink