test(nestjs) fix broken unit tests (context creator)

Author: kamilmysliwiec

packages/microservices/test/context/rpc-context-creator.spec.ts

@@ -1,27 +1,25 @@
-import * as sinon from 'sinon';
 import { expect } from 'chai';
+import { of } from 'rxjs';
+import * as sinon from 'sinon';
+import { ApplicationConfig } from '../../../core/application-config';
+import { GuardsConsumer } from '../../../core/guards/guards-consumer';
+import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
+import { NestContainer } from '../../../core/injector/container';
+import { InterceptorsConsumer } from '../../../core/interceptors/interceptors-consumer';
+import { InterceptorsContextCreator } from '../../../core/interceptors/interceptors-context-creator';
+import { PipesConsumer } from '../../../core/pipes/pipes-consumer';
+import { PipesContextCreator } from '../../../core/pipes/pipes-context-creator';
+import { RpcException } from '../../index';
 import {
+  Component,
   Guard,
   Injectable,
   UseGuards,
-  Component,
   UsePipes,
 } from './../../../common';
-import { RpcProxy } from './../../context/rpc-proxy';
-import { RpcContextCreator } from './../../context/rpc-context-creator';
-import { RpcExceptionsHandler } from '../../exceptions/rpc-exceptions-handler';
 import { ExceptionFiltersContext } from './../../context/exception-filters-context';
-import { PipesContextCreator } from '../../../core/pipes/pipes-context-creator';
-import { PipesConsumer } from '../../../core/pipes/pipes-consumer';
-import { PARAMTYPES_METADATA } from '../../../common/constants';
-import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
-import { GuardsConsumer } from '../../../core/guards/guards-consumer';
-import { NestContainer } from '../../../core/injector/container';
-import { Observable, of } from 'rxjs';
-import { RpcException } from '../../index';
-import { InterceptorsContextCreator } from '../../../core/interceptors/interceptors-context-creator';
-import { InterceptorsConsumer } from '../../../core/interceptors/interceptors-consumer';
-import { ApplicationConfig } from '../../../core/application-config';
+import { RpcContextCreator } from './../../context/rpc-context-creator';
+import { RpcProxy } from './../../context/rpc-proxy';
 
 @Guard()
 class TestGuard {
@@ -102,6 +100,9 @@ describe('RpcContextCreator', () => {
     describe('when proxy called', () => {
       it('should call guards consumer `tryActivate`', async () => {
         const tryActivateSpy = sinon.spy(guardsConsumer, 'tryActivate');
+        sinon
+          .stub(guardsContextCreator, 'create')
+          .callsFake(() => [{ canActivate: () => true }]);
         const proxy = await contextCreator.create(
           instance,
           instance.test,
@@ -168,4 +169,11 @@ describe('RpcContextCreator', () => {
       });
     });
   });
+  describe('createGuardsFn', () => {
+    it('should throw exception when "tryActivate" returns false', () => {
+      const guardsFn = contextCreator.createGuardsFn([null], null, null);
+      sinon.stub(guardsConsumer, 'tryActivate').callsFake(() => false);
+      expect(guardsFn([])).to.eventually.throw();
+    });
+  });
 });

packages/websockets/test/context/ws-context-creator.spec.ts

@@ -1,26 +1,24 @@
-import * as sinon from 'sinon';
 import { expect } from 'chai';
+import { of } from 'rxjs';
+import * as sinon from 'sinon';
+import { GuardsConsumer } from '../../../core/guards/guards-consumer';
+import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
+import { NestContainer } from '../../../core/injector/container';
+import { InterceptorsConsumer } from '../../../core/interceptors/interceptors-consumer';
+import { InterceptorsContextCreator } from '../../../core/interceptors/interceptors-context-creator';
+import { PipesConsumer } from '../../../core/pipes/pipes-consumer';
+import { PipesContextCreator } from '../../../core/pipes/pipes-context-creator';
+import { WsException } from '../../index';
 import {
+  Component,
   Guard,
   Injectable,
   UseGuards,
-  Component,
   UsePipes,
 } from './../../../common';
-import { WsProxy } from './../../context/ws-proxy';
-import { WsContextCreator } from './../../context/ws-context-creator';
-import { WsExceptionsHandler } from '../../exceptions/ws-exceptions-handler';
 import { ExceptionFiltersContext } from './../../context/exception-filters-context';
-import { PipesContextCreator } from '../../../core/pipes/pipes-context-creator';
-import { PipesConsumer } from '../../../core/pipes/pipes-consumer';
-import { PARAMTYPES_METADATA } from '../../../common/constants';
-import { GuardsContextCreator } from '../../../core/guards/guards-context-creator';
-import { GuardsConsumer } from '../../../core/guards/guards-consumer';
-import { NestContainer } from '../../../core/injector/container';
-import { Observable, of } from 'rxjs';
-import { WsException } from '../../index';
-import { InterceptorsContextCreator } from '../../../core/interceptors/interceptors-context-creator';
-import { InterceptorsConsumer } from '../../../core/interceptors/interceptors-consumer';
+import { WsContextCreator } from './../../context/ws-context-creator';
+import { WsProxy } from './../../context/ws-proxy';
 
 @Guard()
 class TestGuard {
@@ -99,6 +97,9 @@ describe('WsContextCreator', () => {
     describe('when proxy called', () => {
       it('should call guards consumer `tryActivate`', async () => {
         const tryActivateSpy = sinon.spy(guardsConsumer, 'tryActivate');
+        sinon
+          .stub(guardsContextCreator, 'create')
+          .callsFake(() => [{ canActivate: () => true }]);
         const proxy = await contextCreator.create(
           instance,
           instance.test,
@@ -165,4 +166,11 @@ describe('WsContextCreator', () => {
       });
     });
   });
+  describe('createGuardsFn', () => {
+    it('should throw exception when "tryActivate" returns false', () => {
+      const guardsFn = contextCreator.createGuardsFn([null], null, null);
+      sinon.stub(guardsConsumer, 'tryActivate').callsFake(() => false);
+      expect(guardsFn([])).to.eventually.throw();
+    });
+  });
 });