fix: sonarcloud code smell public test method

Ivanf1 · Ivanf1 · commit 75ca861253e2 · 2023-11-27T11:03:56.000+01:00
diff --git a/src/test/java/org/apache/commons/csv/TokenMatchersTest.java b/src/test/java/org/apache/commons/csv/TokenMatchersTest.java
@@ -27,49 +27,49 @@
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
-public class TokenMatchersTest {
+ class TokenMatchersTest {
 
     private Token token;
 
     @BeforeEach
-    public void setUp() {
+     void setUp() {
         token = new Token();
         token.type = Token.Type.TOKEN;
         token.isReady = true;
         token.content.append("content");
     }
 
     @Test
-    public void testHasContent() {
+     void testHasContent() {
         assertFalse(hasContent("This is not the token's content").matches(token));
         assertTrue(hasContent("content").matches(token));
     }
 
     @Test
-    public void testHasType() {
+     void testHasType() {
         assertFalse(hasType(Token.Type.COMMENT).matches(token));
         assertFalse(hasType(Token.Type.EOF).matches(token));
         assertFalse(hasType(Token.Type.EORECORD).matches(token));
         assertTrue(hasType(Token.Type.TOKEN).matches(token));
     }
 
     @Test
-    public void testIsReady() {
+     void testIsReady() {
         assertTrue(isReady().matches(token));
         token.isReady = false;
         assertFalse(isReady().matches(token));
     }
 
     @Test
-    public void testMatches() {
+     void testMatches() {
         assertTrue(matches(Token.Type.TOKEN, "content").matches(token));
         assertFalse(matches(Token.Type.EOF, "content").matches(token));
         assertFalse(matches(Token.Type.TOKEN, "not the content").matches(token));
         assertFalse(matches(Token.Type.EORECORD, "not the content").matches(token));
     }
 
     @Test
-    public void testToString() {
+     void testToString() {
         assertTrue(matches(Token.Type.TOKEN, "content").matches(token));
         assertEquals("TOKEN", token.type.name());
         assertEquals("TOKEN [content]", token.toString());
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv148Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv148Test.java
@@ -22,10 +22,10 @@
 import org.apache.commons.csv.QuoteMode;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv148Test {
+ class JiraCsv148Test {
 
     @Test
-    public void testWithIgnoreSurroundingSpacesEmpty() {
+     void testWithIgnoreSurroundingSpacesEmpty() {
         // @formatter:off
         final CSVFormat format = CSVFormat.DEFAULT.builder()
             .setQuoteMode(QuoteMode.ALL)
@@ -47,7 +47,7 @@ public void testWithIgnoreSurroundingSpacesEmpty() {
      * you can remove the leading and trailing spaces, tabs and other symbols.
      */
     @Test
-    public void testWithTrimEmpty() {
+     void testWithTrimEmpty() {
         // @formatter:off
         final CSVFormat format = CSVFormat.DEFAULT.builder()
             .setQuoteMode(QuoteMode.ALL)
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv149Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv149Test.java
@@ -27,12 +27,12 @@
 import org.apache.commons.csv.CSVRecord;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv149Test {
+ class JiraCsv149Test {
 
     private static final String CR_LF = "\r\n";
 
     @Test
-    public void testJiraCsv149EndWithEOL() throws IOException {
+     void testJiraCsv149EndWithEOL() throws IOException {
         testJiraCsv149EndWithEolAtEof(true);
     }
 
@@ -59,7 +59,7 @@ private void testJiraCsv149EndWithEolAtEof(final boolean eolAtEof) throws IOExce
     }
 
     @Test
-    public void testJiraCsv149EndWithoutEOL() throws IOException {
+     void testJiraCsv149EndWithoutEOL() throws IOException {
         testJiraCsv149EndWithEolAtEof(false);
     }
 }
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv154Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv154Test.java
@@ -24,10 +24,10 @@
 import org.apache.commons.csv.CSVPrinter;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv154Test {
+ class JiraCsv154Test {
 
     @Test
-    public void testJiraCsv154_withCommentMarker() throws IOException {
+     void testJiraCsv154_withCommentMarker() throws IOException {
         final String comment = "This is a header comment";
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
@@ -46,7 +46,7 @@ public void testJiraCsv154_withCommentMarker() throws IOException {
     }
 
     @Test
-    public void testJiraCsv154_withHeaderComments() throws IOException {
+     void testJiraCsv154_withHeaderComments() throws IOException {
         final String comment = "This is a header comment";
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv167Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv167Test.java
@@ -29,15 +29,15 @@
 import org.apache.commons.csv.QuoteMode;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv167Test {
+ class JiraCsv167Test {
 
     private Reader getTestReader() {
         return new InputStreamReader(
             ClassLoader.getSystemClassLoader().getResourceAsStream("org/apache/commons/csv/csv-167/sample1.csv"));
     }
 
     @Test
-    public void testParse() throws IOException {
+     void testParse() throws IOException {
         int totcomment = 0;
         int totrecs = 0;
         try (final Reader reader = getTestReader(); final BufferedReader br = new BufferedReader(reader)) {
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv198Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv198Test.java
@@ -28,7 +28,7 @@
 import org.apache.commons.csv.CSVParser;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv198Test {
+ class JiraCsv198Test {
 
     // @formatter:off
     private static final CSVFormat CSV_FORMAT = CSVFormat.EXCEL.builder()
@@ -39,7 +39,7 @@ public class JiraCsv198Test {
     // @formatter:on
 
     @Test
-    public void test() throws UnsupportedEncodingException, IOException {
+     void test() throws UnsupportedEncodingException, IOException {
         final InputStream pointsOfReference = getClass().getResourceAsStream("/org/apache/commons/csv/CSV-198/optd_por_public.csv");
         assertNotNull(pointsOfReference);
         try (@SuppressWarnings("resource")
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv203Test.java
@@ -27,10 +27,10 @@
  * JIRA: <a href="https://issues.apache.org/jira/browse/CSV-203">withNullString value is printed without quotes when
  * QuoteMode.ALL is specified</a>
  */
-public class JiraCsv203Test {
+ class JiraCsv203Test {
 
     @Test
-    public void testQuoteModeAll() throws Exception {
+     void testQuoteModeAll() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
@@ -46,7 +46,7 @@ public void testQuoteModeAll() throws Exception {
     }
 
     @Test
-    public void testQuoteModeAllNonNull() throws Exception {
+     void testQuoteModeAllNonNull() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
@@ -62,7 +62,7 @@ public void testQuoteModeAllNonNull() throws Exception {
     }
 
     @Test
-    public void testQuoteModeMinimal() throws Exception {
+     void testQuoteModeMinimal() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
@@ -78,7 +78,7 @@ public void testQuoteModeMinimal() throws Exception {
     }
 
     @Test
-    public void testQuoteModeNonNumeric() throws Exception {
+     void testQuoteModeNonNumeric() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
@@ -94,7 +94,7 @@ public void testQuoteModeNonNumeric() throws Exception {
     }
 
     @Test
-    public void testWithEmptyValues() throws Exception {
+     void testWithEmptyValues() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
@@ -111,7 +111,7 @@ public void testWithEmptyValues() throws Exception {
     }
 
     @Test
-    public void testWithoutNullString() throws Exception {
+     void testWithoutNullString() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 //.setNullString("N/A")
@@ -127,7 +127,7 @@ public void testWithoutNullString() throws Exception {
     }
 
     @Test
-    public void testWithoutQuoteMode() throws Exception {
+     void testWithoutQuoteMode() throws Exception {
         // @formatter:off
         final CSVFormat format = CSVFormat.EXCEL.builder()
                 .setNullString("N/A")
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv206Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv206Test.java
@@ -28,10 +28,10 @@
 import org.apache.commons.csv.CSVRecord;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv206Test {
+ class JiraCsv206Test {
 
     @Test
-    public void testJiraCsv206MultipleCharacterDelimiter() throws IOException {
+     void testJiraCsv206MultipleCharacterDelimiter() throws IOException {
         // Read with multiple character delimiter
         final String source = "FirstName[|]LastName[|]Address\r\nJohn[|]Smith[|]123 Main St.";
         final StringReader reader = new StringReader(source);
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv211Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv211Test.java
@@ -25,10 +25,10 @@
 import org.apache.commons.csv.CSVParser;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv211Test {
+ class JiraCsv211Test {
 
     @Test
-    public void testJiraCsv211Format() throws IOException {
+     void testJiraCsv211Format() throws IOException {
         // @formatter:off
         final CSVFormat printFormat = CSVFormat.DEFAULT.builder()
             .setDelimiter('\t')
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv213Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv213Test.java
@@ -36,7 +36,7 @@
  * you want, you need to open a new CSVParser.
  * </p>
  */
-public class JiraCsv213Test {
+ class JiraCsv213Test {
 
     private void createEndChannel(final File csvFile) {
         // @formatter:off
@@ -62,7 +62,7 @@ private void createEndChannel(final File csvFile) {
     }
 
     @Test
-    public void test() {
+     void test() {
         createEndChannel(new File("src/test/resources/org/apache/commons/csv/CSV-213/999751170.patch.csv"));
     }
 }
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv247Test.java
@@ -32,10 +32,10 @@
 import org.apache.commons.csv.CSVRecord;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv247Test {
+ class JiraCsv247Test {
 
     @Test
-    public void testHeadersMissingOneColumnWhenAllowingMissingColumnNames() throws Exception {
+     void testHeadersMissingOneColumnWhenAllowingMissingColumnNames() throws Exception {
         final CSVFormat format = CSVFormat.DEFAULT.builder().setHeader().setAllowMissingColumnNames(true).build();
 
         assertTrue(format.getAllowMissingColumnNames(), "We should allow missing column names");
@@ -61,7 +61,7 @@ record = iterator.next();
     }
 
     @Test
-    public void testHeadersMissingThrowsWhenNotAllowingMissingColumnNames() {
+     void testHeadersMissingThrowsWhenNotAllowingMissingColumnNames() {
         final CSVFormat format = CSVFormat.DEFAULT.builder().setHeader().build();
 
         assertFalse(format.getAllowMissingColumnNames(), "By default we should not allow missing column names");
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv248Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv248Test.java
@@ -30,7 +30,7 @@
 import org.apache.commons.csv.CSVRecord;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv248Test {
+ class JiraCsv248Test {
     private static InputStream getTestInput() {
         return ClassLoader.getSystemClassLoader().getResourceAsStream("org/apache/commons/csv/CSV-248/csvRecord.bin");
     }
@@ -46,7 +46,7 @@ private static InputStream getTestInput() {
      * @throws ClassNotFoundException If the CSVRecord cannot be deserialized
      */
     @Test
-    public void testJiraCsv248() throws IOException, ClassNotFoundException {
+     void testJiraCsv248() throws IOException, ClassNotFoundException {
         // Record was originally created using CSV version 1.6 with the following code:
         // try (final CSVParser parser = CSVParser.parse("A,B\n#my comment\nOne,Two",
         // CSVFormat.DEFAULT.builder().setHeader().setCommentMarker('#'))) {
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv249Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv249Test.java
@@ -30,10 +30,10 @@
 import org.apache.commons.csv.CSVRecord;
 import org.junit.jupiter.api.Test;
 
-public class JiraCsv249Test {
+ class JiraCsv249Test {
 
     @Test
-    public void testJiraCsv249() throws IOException {
+     void testJiraCsv249() throws IOException {
         final CSVFormat csvFormat = CSVFormat.DEFAULT.builder().setEscape('\\').build();
         final StringWriter stringWriter = new StringWriter();
         try (CSVPrinter printer = new CSVPrinter(stringWriter, csvFormat)) {
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv253Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv253Test.java
@@ -31,7 +31,7 @@
 /**
  * Setting QuoteMode:ALL_NON_NULL or NON_NUMERIC can distinguish between empty string columns and absent value columns.
  */
-public class JiraCsv253Test {
+ class JiraCsv253Test {
 
     private void assertArrayEqual(final String[] expected, final CSVRecord actual) {
         for (int i = 0; i < expected.length; i++) {
@@ -40,7 +40,7 @@ private void assertArrayEqual(final String[] expected, final CSVRecord actual) {
     }
 
     @Test
-    public void testHandleAbsentValues() throws IOException {
+     void testHandleAbsentValues() throws IOException {
         final String source = "\"John\",,\"Doe\"\n" + ",\"AA\",123\n" + "\"John\",90,\n" + "\"\",,90";
         final CSVFormat csvFormat = CSVFormat.DEFAULT.builder().setQuoteMode(QuoteMode.NON_NUMERIC).build();
         try (final CSVParser parser = csvFormat.parse(new StringReader(source))) {
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv263Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv263Test.java
@@ -30,10 +30,10 @@
 /**
  * Tests [CSV-263] Print from Reader with embedded quotes generates incorrect output.
  */
-public class JiraCsv263Test {
+ class JiraCsv263Test {
 
     @Test
-    public void testPrintFromReaderWithQuotes() throws IOException {
+     void testPrintFromReaderWithQuotes() throws IOException {
         // @formatter:off
         final CSVFormat format = CSVFormat.RFC4180.builder()
             .setDelimiter(',')
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv264Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv264Test.java
@@ -33,7 +33,7 @@
  *
  * @see <a href="https://issues.apache.org/jira/browse/CSV-264">Jira Ticker</a>
  */
-public class JiraCsv264Test {
+ class JiraCsv264Test {
 
     private static final String CSV_STRING = "\"\",\"B\",\"\"\n" +
                                              "\"1\",\"2\",\"3\"\n" +
@@ -47,7 +47,7 @@ public class JiraCsv264Test {
                                                  "\"6\",\"7\",\"\",\"\",\"10\"";
 
     @Test
-    public void testJiraCsv264() {
+     void testJiraCsv264() {
         final CSVFormat csvFormat = CSVFormat.DEFAULT
             .builder()
             .setHeader()
@@ -61,7 +61,7 @@ public void testJiraCsv264() {
     }
 
     @Test
-    public void testJiraCsv264WithGapAllowEmpty() throws IOException {
+     void testJiraCsv264WithGapAllowEmpty() throws IOException {
         final CSVFormat csvFormat = CSVFormat.DEFAULT
             .builder()
             .setHeader()
@@ -75,7 +75,7 @@ public void testJiraCsv264WithGapAllowEmpty() throws IOException {
     }
 
     @Test
-    public void testJiraCsv264WithGapDisallow() {
+     void testJiraCsv264WithGapDisallow() {
         final CSVFormat csvFormat = CSVFormat.DEFAULT
             .builder()
             .setHeader()
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv265Test.java
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv271Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv271Test.java
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv288Test.java
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv290Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv290Test.java
diff --git a/src/test/java/org/apache/commons/csv/issues/JiraCsv93Test.java b/src/test/java/org/apache/commons/csv/issues/JiraCsv93Test.java

Original file line number	Diff line number	Diff line change
`@@ -27,12 +27,12 @@`
`27`	`27`	`import org.apache.commons.csv.CSVRecord;`
`28`	`28`	`import org.junit.jupiter.api.Test;`
`29`	`29`
`30`		`-public class JiraCsv149Test {`
	`30`	`+ class JiraCsv149Test {`
`31`	`31`
`32`	`32`	`private static final String CR_LF = "\r\n";`
`33`	`33`
`34`	`34`	`@Test`
`35`		`- public void testJiraCsv149EndWithEOL() throws IOException {`
	`35`	`+ void testJiraCsv149EndWithEOL() throws IOException {`
`36`	`36`	`testJiraCsv149EndWithEolAtEof(true);`
`37`	`37`	`}`
`38`	`38`
`@@ -59,7 +59,7 @@ private void testJiraCsv149EndWithEolAtEof(final boolean eolAtEof) throws IOExce`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`@Test`
`62`		`- public void testJiraCsv149EndWithoutEOL() throws IOException {`
	`62`	`+ void testJiraCsv149EndWithoutEOL() throws IOException {`
`63`	`63`	`testJiraCsv149EndWithEolAtEof(false);`
`64`	`64`	`}`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@`
`36`	`36`	`* you want, you need to open a new CSVParser.`
`37`	`37`	`* </p>`
`38`	`38`	`*/`
`39`		`-public class JiraCsv213Test {`
	`39`	`+ class JiraCsv213Test {`
`40`	`40`
`41`	`41`	`private void createEndChannel(final File csvFile) {`
`42`	`42`	`// @formatter:off`
`@@ -62,7 +62,7 @@ private void createEndChannel(final File csvFile) {`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`@Test`
`65`		`- public void test() {`
	`65`	`+ void test() {`
`66`	`66`	`createEndChannel(new File("src/test/resources/org/apache/commons/csv/CSV-213/999751170.patch.csv"));`
`67`	`67`	`}`
`68`	`68`	`}`