fix: sonarcloud code smell

Author: Ivanf1

src/main/java/org/apache/commons/csv/CSVParser.java

@@ -504,38 +504,7 @@ private Headers createHeaders() throws IOException {
             }
 
             // build the name to index mappings
-            if (headerRecord != null) {
-                // Track an occurrence of a null, empty or blank header.
-                boolean observedMissing = false;
-                for (int i = 0; i < headerRecord.length; i++) {
-                    final String header = headerRecord[i];
-                    final boolean blankHeader = CSVFormat.isBlank(header);
-                    if (blankHeader && !this.format.getAllowMissingColumnNames()) {
-                        throw new IllegalArgumentException(
-                            "A header name is missing in " + Arrays.toString(headerRecord));
-                    }
-
-                    final boolean containsHeader = blankHeader ? observedMissing : hdrMap.containsKey(header);
-                    final DuplicateHeaderMode headerMode = this.format.getDuplicateHeaderMode();
-                    final boolean duplicatesAllowed = headerMode == DuplicateHeaderMode.ALLOW_ALL;
-                    final boolean emptyDuplicatesAllowed = headerMode == DuplicateHeaderMode.ALLOW_EMPTY;
-
-                    if (containsHeader && !duplicatesAllowed && !(blankHeader && emptyDuplicatesAllowed)) {
-                        throw new IllegalArgumentException(
-                            String.format(
-                                "The header contains a duplicate name: \"%s\" in %s. If this is valid then use CSVFormat.Builder.setDuplicateHeaderMode().",
-                                header, Arrays.toString(headerRecord)));
-                    }
-                    observedMissing |= blankHeader;
-                    if (header != null) {
-                        hdrMap.put(header, Integer.valueOf(i));
-                        if (headerNames == null) {
-                            headerNames = new ArrayList<>(headerRecord.length);
-                        }
-                        headerNames.add(header);
-                    }
-                }
-            }
+            headerNames = getHeaderNames(headerRecord, hdrMap, headerNames);
         }
         if (headerNames == null) {
             headerNames = Collections.emptyList(); // immutable
@@ -545,6 +514,42 @@ private Headers createHeaders() throws IOException {
         return new Headers(hdrMap, headerNames);
     }
 
+    private List<String> getHeaderNames(String[] headerRecord, Map<String, Integer> hdrMap, List<String> headerNames) {
+        if (headerRecord != null) {
+            // Track an occurrence of a null, empty or blank header.
+            boolean observedMissing = false;
+            for (int i = 0; i < headerRecord.length; i++) {
+                final String header = headerRecord[i];
+                final boolean blankHeader = CSVFormat.isBlank(header);
+                if (blankHeader && !this.format.getAllowMissingColumnNames()) {
+                    throw new IllegalArgumentException(
+                        "A header name is missing in " + Arrays.toString(headerRecord));
+                }
+
+                final boolean containsHeader = blankHeader ? observedMissing : hdrMap.containsKey(header);
+                final DuplicateHeaderMode headerMode = this.format.getDuplicateHeaderMode();
+                final boolean duplicatesAllowed = headerMode == DuplicateHeaderMode.ALLOW_ALL;
+                final boolean emptyDuplicatesAllowed = headerMode == DuplicateHeaderMode.ALLOW_EMPTY;
+
+                if (containsHeader && !duplicatesAllowed && !(blankHeader && emptyDuplicatesAllowed)) {
+                    throw new IllegalArgumentException(
+                        String.format(
+                            "The header contains a duplicate name: \"%s\" in %s. If this is valid then use CSVFormat.Builder.setDuplicateHeaderMode().",
+                            header, Arrays.toString(headerRecord)));
+                }
+                observedMissing |= blankHeader;
+                if (header != null) {
+                    hdrMap.put(header, Integer.valueOf(i));
+                    if (headerNames == null) {
+                        headerNames = new ArrayList<>(headerRecord.length);
+                    }
+                    headerNames.add(header);
+                }
+            }
+        }
+        return headerNames;
+    }
+
     /**
      * Gets the current line number in the input stream.
      *