Skip to content

Improve documentation with usual caveats #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 23, 2019

Conversation

X-Ryl669
Copy link

This adds a documents explaining the pattern that works best and those to avoid. I think it's required for newcomers.

@coveralls
Copy link

coveralls commented Aug 21, 2019

Coverage Status

Coverage remained the same at 97.048% when pulling 322c998 on X-Ryl669:improveDoc into 33a3722 on JPeer264:master.

@X-Ryl669 X-Ryl669 force-pushed the improveDoc branch 3 times, most recently from c573841 to 9165d28 Compare August 22, 2019 20:20
Copy link
Owner

@JPeer264 JPeer264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome documentation! Just one more thing

@@ -100,6 +100,12 @@ try {
- [rcs.loadMapping](docs/api/loadMapping.md)
- [rcs.config](docs/api/config.md)

## Caveats
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add this new section on the Content list?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sure.

@X-Ryl669 X-Ryl669 force-pushed the improveDoc branch 2 times, most recently from 2c73cf5 to 322c998 Compare August 23, 2019 20:45
@JPeer264 JPeer264 merged commit 4cf2420 into JPeer264:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants