Adds MonthFormat and Animation options + GetSelectedDate and Validate methods#17
Merged
Conversation
animation's speed.
user to specify which jQuery (not jQuery UI effects) animation method they want to use.
format for parsing and displaying dates.
Makes all callbacks this refer to the the input element + Makes UseInputMask option aware of the MonthFormat option + Allows using a third party library for parsing and fromating months + Added var delecration in various methods to help uglify with name mangling
Makes </script> tags visible in the README.md (I checked it you now just copy and paste the tags and the plugin will work).
Owner
|
Benjamin! You are a rock star! I was out of town on travel all weekend and just got back. Give me a few days to soak this up then I will probably merge it in. Keep it coming if you got more! THANKS! |
Owner
|
Nice fiddle you put together! Thats great! Woot! I love your work! |
Collaborator
Author
Owner
|
I really like the Date Picker formatting and parsing. That is some great work that really shows strong understanding of the jQuery UI internals. I saw you did some extra work there to ensure unit tests were not broken, that is great work too. It is a pleasure to work with you Benjamin, you are a true professional. I am going to merge this and close it out now. Then I will update the fiddle. |
KidSysco
added a commit
that referenced
this pull request
Oct 8, 2015
Adds MonthFormat and Animation options + GetSelectedDate and Validate methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a pull request for #16.
I've added a couple of new options:
I've also added some new methods:
I've also added some usability features:
All events
thisnew refer to the associated input field, it would be grate if you can add some tests for$(this)....When I first added the new code to the new fiddle I broke a GetSelectedMonthYear unit test that tested that the return value was '2/2012' and the new code was returning '02/2012' (because I was using the MonthFormat option).
I have to admit that when I first refactored this method I thought it use to be a private method that was made public because It had all of that validate code which I thought had nothing to do with the method.
But when I first looked at the documentation I was surprised because:
So I added the Validate method which I believe better reflects what it does and returns a Date that you can interact with and get exactly what you want out of it without having to parse a string or use the lengthy GetSelectedMonth and GetSelectedYear methods.
I would appreciate it if you can look at my new documentation and tell me if I have any typos (my spelling isn't perfect).