Prevents the menu from closing when the user clicks the input field#23
Merged
Conversation
Closed
KidSysco
added a commit
that referenced
this pull request
Oct 19, 2015
Prevents the menu from closing when the user clicks the input field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #22.
The culprit was my quick fix for #19
It was placed right before this:
So when the user clicks the input field the opened menu will first be closed and then
!this._visiblewill evaluate to true and the menu will be reopened.I fixed this the by moving the close opened menu code (and some other code) into the
if (!this._visible).