Skip to content

Makes the menu open when the user focuses/tabs to the input field#30

Merged
KidSysco merged 1 commit into
KidSysco:masterfrom
benjamin-albert:master
Nov 19, 2015
Merged

Makes the menu open when the user focuses/tabs to the input field#30
KidSysco merged 1 commit into
KidSysco:masterfrom
benjamin-albert:master

Conversation

@benjamin-albert
Copy link
Copy Markdown
Collaborator

This is a fix for #29

I've also replaced tabs with spaces (that's why so may lines have changed) and removed the unnecessary _showIcon method.

I've written unit tests that pass in all modern browsers except for IE.

IE seems to invoke the focus event handler asynchronously which results in the new tests failing only in IE.

I push the new tests to a branch called focus_unit_tests.

I have to find some time at work (where I have a windows machine) to make those tests pass in IE.

I would appreciate it if you could take a look and fix those test because I'm kind of busy at work and I don't feel like asking for someone else's windows machine just to make these tests pass in IE.

KidSysco added a commit that referenced this pull request Nov 19, 2015
Makes the menu open when the user focuses/tabs to the input field
@KidSysco KidSysco merged commit ec077a5 into KidSysco:master Nov 19, 2015
@KidSysco
Copy link
Copy Markdown
Owner

I just took your new tests from your test branch, put them into my Master branch and modified them to work in IE. Synching up with this repo should get you the updated tests. Let me know if I missed anything.

@benjamin-albert
Copy link
Copy Markdown
Collaborator Author

I think you forgot to push the changes I don't see any new commits after the merge commit.

@KidSysco
Copy link
Copy Markdown
Owner

Yes you are correct, my local branch was working perfectly, lol, pushed and
changes are showing now.

Thanks for the speedy turn around Benjamin! It is a pleasure working with
you as always, glad I could help with the tests!

On Thu, Nov 19, 2015 at 8:44 AM, Benjamin Albert notifications@github.com
wrote:

I think you forgot to push the changes I don't see any new commits after
the merge commit.


Reply to this email directly or view it on GitHub
#30 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants