-
Notifications
You must be signed in to change notification settings - Fork 75
The first beta of version 3.0 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
139feac
Makes the mnue look more like datepicker
benjamin-albert 8bcce73
Fixed an issue with inline menus's width
benjamin-albert 5373cb0
Merge branch 'master' into 3.0_prototype
benjamin-albert 30d3273
Create .travis.yml
benjamin-albert 14dfe2f
Update package.json for Travis CI
benjamin-albert a0f7622
Updated Node.js in .travis.yml
benjamin-albert 0f73c87
Merge remote-tracking branch 'origin/3.0_prototype' into 3.0_prototype
benjamin-albert dbe9a7b
Added Travis CI and built with grunt badges to README
benjamin-albert 1a7d29e
Makes the next and previous buttons have a transparent background
benjamin-albert e1fa4b8
Removes the width:60px rule from .month-year-input
benjamin-albert 18a40a2
Adds themes test page (test/themes.html)
benjamin-albert cc8ded2
Merge remote-tracking branch 'kidsysco/master' into 3.0_prototype
benjamin-albert fc99cc4
Turns the year title into a button that fades in the text
benjamin-albert 1f67723
Version bump in README.md
benjamin-albert b178132
Makes jump years button update it's text when the year changes
benjamin-albert 46dd482
Renames classes and properties to reflect the new jump
benjamin-albert e314ddb
Ajusts the Start Year Option Tests to the new jump years button
benjamin-albert dcbb730
Ajusts Events and context + year buttons are disabled tests
benjamin-albert 22b94c8
Ajusts the rest of the tests to the new jump years button structure
benjamin-albert 6224289
Extracts the new jump years button code into its own function
benjamin-albert 3dc868a
Makes moving forward and backwards through the years jump 12 year
benjamin-albert 14dd334
Fixes an issue that prevented test from passing in IE.
benjamin-albert f013d7f
IE 8 support: Replaces use of .indexOf() with $.inArray()
benjamin-albert 02440bc
Merge branch 'master' into 3.0_prototype
benjamin-albert 5bfcc70
Makes the jump years button turn into Back to 2016
benjamin-albert 7b5305f
Makes sure the Jump Years label won't show if the user clicks
benjamin-albert b429653
Merge branch 'master' into 3.0_prototype + bump to alpha6
236da1a
Adds MonthPicker.css to the main files in bower.json
832b111
Merge branch 'master' into 3.0_prototype
a119ac2
Improves CSS layout and adds comments.
124ec3b
Bumps version to 3.0-beta1
70f724e
Renames next/prev5Years i18n properties to next/prev12Years and
a3bbb04
Adds MonthPickerButton and makes all buttons in the header use it
079649d
Makes MonthPickerButton a private widget named _headerButton
fca9ef3
Fixes rare memory leak + renames _event() argument
5d63578
Merge branch 'master' into 3.0_progress
df3eb04
Makes the Title buttons test use an existing
a5b18e5
Adds the Back to 2015 button test
4fd4eff
Ajusts RTL support for the new designs CSS
116d71d
Makes the month buttons margin use em instead of px
7a7bd71
Adds the _applyButtonHint function
af6dee7
Removes _headerButton
b182dbf
Disables user selection on the year table (header)
be0aea4
Restores the jump years hint if the user closed the menu
3cbb69f
Adds comments to the _applyButtonHint function
2363473
Removes unnecessary margin from the year table buttons
benjamin-albert 69fec96
Makes grunt produce a minified CSS file
benjamin-albert 89d7225
Reduces the font size of the jump years button
benjamin-albert 81db6f0
Adds the i18n button test
benjamin-albert 7589c32
Gives new class names to <td>s in the month-picker-year-table
benjamin-albert c4ce4d6
Renames _jumpYearsButton to _titleButton
19fe092
Adds the 3.x Upgrade Guide
90e3d2c
Adds a link to the 3.0 Upgrade Guide to README.md
e1fc323
Runs grunt
benjamin-albert cb168bb
Adds notice about removing the width: 60px; rule
benjamin-albert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Adds the 3.x Upgrade Guide
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| # 3.x Upgrade Guide | ||
|
|
||
| Version 3.x features a redesigned Month Picker menu which: | ||
|
|
||
| 1. Looks more consistent with [jQuery UI Datepicker](https://jqueryui.com/datepicker/). | ||
| 2. Turns the Year title into a button which gives the user a "hint" about | ||
| the Jump Years menu when they mouse over it. | ||
| 3. Allows the user to return to the year they clicked Jump years at. | ||
|
|
||
| See it for yourself at the [demo on JSFiddle](http://jsfiddle.net/kidsysco/JeZap/). | ||
|
|
||
| ## i18n property name changes | ||
| If you changed out the buttons, labels or other text using the | ||
| i18n support you should rename and translate `next5Years` to `next12Years` | ||
| and `prev5Years` to `prev12Years`. | ||
|
|
||
| You should also add the `backTo` property, which is used for the | ||
| new *Back to 2016* button when the user enters the Jump Year menu. | ||
|
|
||
| ## CSS changes | ||
| Version 3.x uses `em` instead of `px` units. | ||
| This means that the menu determines it's size according to the | ||
| `body` element's `font-size`. | ||
|
|
||
| If you need to resize the menu, add this rule to your CSS: | ||
| ``` | ||
| /* Makes the Month Picker menu 20% bigger. */ | ||
| .month-picker { | ||
| font-size: 1.2em; | ||
| } | ||
| ``` | ||
|
|
||
| ## Markup changes | ||
| If you've applied custom CSS to the Month Picker menu, please note that: | ||
|
|
||
| The following elements were removed: | ||
| ``` | ||
| <td class="year-container-all"> | ||
| <div id="year-container"> | ||
| <span class="year-title" /> | ||
| <span class="year" /> | ||
| </div> | ||
| ``` | ||
| They were replaces by `<td class='month-picker-title'><a /></td>`. | ||
| The `<a>` tag is a [jQyery UI Button](https://jqueryui.com/button/). | ||
|
|
||
| The following elements: | ||
| ``` | ||
| <td class="previous-year"><button /></td> | ||
| <td class="next-year"><button /></td> | ||
| ``` | ||
| were replaced by: | ||
| ``` | ||
| <td class="month-picker-next"><a /></td> | ||
| <td class="month-picker-previous"><a /></td> | ||
| ``` | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KidSysco Perhaps we should say something here about the update being simple, and in some cases will only require downloading the new minified version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Benjamin,
Sorry I have not gotten back sooner, I have been looking at this though. It
is a lot of work and it is taking me a while to get my head around
everything here.
I like everything I see so far, everything here was discussed prior. You
set a goal, you worked towards that goal and yea, I think you are just
about there!
I will get back to you shortly when I get through everything.
r.
On Wed, Jan 20, 2016 at 12:59 AM, Benjamin Albert notifications@github.com
wrote:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gives me something to push to kickoff Travic-CI!
good thinking Benjamin!
:D
On Wed, Jan 20, 2016 at 12:59 AM, Benjamin Albert notifications@github.com
wrote: