Re #46: Restructures the project to provide a working demo#47
Merged
Conversation
instead of the concatenated Demo.min.js/css
This fixes Travis-CI Error: no test specified
and updates the license in package.json Adds a grunt task that adds all the files in the /demo directory to the gh-pages branch and pushes the branch to origin (aka GitHub)
Collaborator
Author
|
Perhaps we should consider renaming the I find the name |
KidSysco
added a commit
that referenced
this pull request
Feb 15, 2016
Re #46: Restructures the project to provide a working demo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we've discussed earlier in #46 and on Slack, this pull moves the
gh-pagesbranch content into the/demodirectory.It also sets up a grunt task to automatically merge the contents of the
/demodirectory with thegh-pagesbranch and push the gh-pages branch to origin (aka GitHub).The gh-pages task needs to be run separately by calling:
IMPORTANT: I've made some change to the demo files so you need to run gh-pages task for them to be visible.
I wanted the minified output to come off of
github.ioservers and to provide a good simple example for installing the plugin in index.html.This required me to:
/demodirectory.demo.min.jsanddemo.min.css./srcdirectory (because I don't want people to see the source and say ohh there's not minded version).IMPORTANT: The new project structure requires us to point the demo on JSFiddle to the new files in the demo directory.
In addition I:
jquery.maskedinput.jsin the/testdirectory come from bower instead of being in the repository.Error: No tests specified messagein the Travis-CI build by adding annpm testcommand that just callsgrunt test.