Fixes #53 by using the mousedown event to close the menu#57
Merged
Conversation
When the user clicks the close button of a jQuery UI dialog it will not close because the Close() method sees that the event.isDefaultPrevented() returns true. This is a workaround until the next major release where we can redesign the way users can prevent the menu from closing.
Collaborator
Author
|
After you merge the PR we need to add a release tag for bower. If you want I can do that. |
Owner
|
Very clever work here that allows us to solve the problem without changing the public API. Great job once again Ben! Thanks for your hard work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the user clicks the close button of a jQuery UI dialog it will not close because the
Close()methodsees that the
event.isDefaultPrevented()returnstrue.I worked around the dialog not closing by using the mousedown event to close the menu instead of the click event.
This is a workaround until the next major release where we can redesign the way users can prevent the menu from closing.
I also updated grunt in
package.jsonand node version in.travis.ymlto fix failing Travis CI build.If you have a better idea to fix this problem that doesn't involve changing the API before a major release I would be discuss it.