Clear alt format field value on "Clear" method call#58
Closed
Yakim wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Thank you for opening a pull request and help make this plugin better for everyone! This change looks good to me, but we should really have a unit test for this. I personally learned a lot from writing unit test for this project and it's changed the way I write JavaScript everywhere. We would be glad to help you if you want to try and write the test. |
Owner
|
I was thinking the same thing. I would be willing to write the test as well. Let me know how you guys want to handle it! |
Owner
|
ok that must be a "no". I will write a unit test for this then commit this week. |
Collaborator
|
@KidSysco I guess we can close this pull request? |
Owner
|
yep! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.