Skip to content

Clear alt format field value on "Clear" method call#58

Closed
Yakim wants to merge 1 commit into
KidSysco:masterfrom
Yakim:patch-1
Closed

Clear alt format field value on "Clear" method call#58
Yakim wants to merge 1 commit into
KidSysco:masterfrom
Yakim:patch-1

Conversation

@Yakim
Copy link
Copy Markdown

@Yakim Yakim commented Apr 28, 2016

No description provided.

@benjamin-albert
Copy link
Copy Markdown
Collaborator

Thank you for opening a pull request and help make this plugin better for everyone!

This change looks good to me, but we should really have a unit test for this.
@Yakim Do you want to try to write the test yourself, or would you prefer that we write the test?

I personally learned a lot from writing unit test for this project and it's changed the way I write JavaScript everywhere.

We would be glad to help you if you want to try and write the test.

@KidSysco
Copy link
Copy Markdown
Owner

I was thinking the same thing. I would be willing to write the test as well. Let me know how you guys want to handle it!

@KidSysco
Copy link
Copy Markdown
Owner

KidSysco commented May 2, 2016

ok that must be a "no".

I will write a unit test for this then commit this week.

@benjamin-albert
Copy link
Copy Markdown
Collaborator

@KidSysco I guess we can close this pull request?

@KidSysco
Copy link
Copy Markdown
Owner

KidSysco commented May 4, 2016

yep!

@KidSysco KidSysco closed this May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants