Makes changing the SelectedMonth option update the AltField.#60
Merged
Conversation
Makes changing the SelectedMonth Option also update the AltField.
Owner
|
Sorry Ben, its a long extended holiday weekend here. Packed, super busy, but I do want to take a closer look and write some tests tomorrow or Tuesday. I will keep you posted. |
Collaborator
Author
|
@KidSysco No need to be sorry. Take your time and enjoy your weekend :) |
Owner
|
I just merged, I am going to write a test now in a dev branch and submit to Ben as a pull request before we do a release for it. It might be nice to have the test in there for this release. |
KidSysco
added a commit
that referenced
this pull request
May 31, 2016
#60 - Added tests for synching the altField when the SelectedMonth option is set as well as clearing any validation message. Also added a test for passing null to the SelectedMonth option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59.
@KidSysco If you want I can write the tests.
We need to add a test for:
SelectedMonthand making sure it clears the value and AltField.SelectedMonthhides the validation message.