Fix algorithm to find balanced var() pairs #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #112
Fix #114
The parenthesis matching was not checking the right balance before.
For the declaration value
var(--box-shadow, 0px 2px 8px 0px rgba(0, 0, 0, 0.5))it would extract the following parts{ "pre": "", "body": "--box-shadow, 0px 2px 8px 0px rgba(0, 0, 0, 0.5", "post": ")" }as it finds the
var(look for the closing)token, which it then finds just after0.5. Instead it should look for()pairs, and check if the opening(is aftervar. This way in the previous case, it would find:{ "pre": "", "body": "--box-shadow, 0px 2px 8px 0px rgba(0, 0, 0, 0.5)", "post": "" }