-
Notifications
You must be signed in to change notification settings - Fork 61
Update playground to use the latest postcss-css-variables@0.19.0
#134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Error: ``` ReferenceError: primordials is not defined ``` Fix from https://stackoverflow.com/a/58394828/796832
postcss-css-variables
postcss-css-variables@0.19.0
mixins({ | ||
mixins: { | ||
'cursor-hand': cursorHandMixin, | ||
'toggle-checkbox-enclosed': toggleCheckboxEnclosedMixin | ||
} | ||
}), | ||
nestedcss, | ||
//nestedcss, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just trying to get the build to work for now.
TODO: Uncomment before merge
"postcss-inline-comment": "npm:postcss-inline-comment@^3.0.0", | ||
"postcss-mixins": "npm:postcss-mixins@^6.0.1", | ||
"postcss-nested": "npm:postcss-nested@^2.1.0", | ||
"postcss-safe-parser": "npm:postcss-safe-parser@^3.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed postcss-safe-parser
because it doesn't seemed used anywhere
@@ -14,12 +14,9 @@ | |||
"localforage": "npm:localforage@^1.2.2", | |||
"lodash.throttle": "npm:lodash.throttle@^4.1.1", | |||
"object-assign": "npm:object-assign@^4.1.1", | |||
"postcss": "npm:postcss@^6.0.8", | |||
"postcss-css-variables": "npm:postcss-css-variables@0.14.0", | |||
"postcss-inline-comment": "npm:postcss-inline-comment@^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed postcss-inline-comment
because it doesn't have a new version that supports postcss@^8
Closing as there are too many roadblocks to get this going (see the Dev notes section in the description) Probably easier just to migrate to the new hot bundler that will break in 5 years |
Update playground to use the latest
postcss-css-variables@0.19.0
Reference: Last time we updated the playground, #111
Todo
postcss@^8
because it's a breaking change in the latest versions ofpostcss-css-variables
npm build
and push the static file buildgh-pages
branchDev notes
To fix the
nanoid
issue you get after installingpostcss@^8
:npm run build
->ENOENT: no such file or directory, open 'postcss-css-variables\playground\jspm_packages\npm\nanoid@3.3.6\non-secure.js'
Fix:
One problem I don't know how to fix is
jspm-loader-css
still usingpostcss@6
and that project looks abandoned and I've forgotten why I use theMeoMix/jspm-loader-css
fork:Which means I'm stuck at this error relating to loading our CSS and
postcss@6
in the stack trace:npm run build
->Error on fetch for postcss-css-variables-playground/postcss/playground.css at file:///postcss-css-variables/playground/src/postcss/playground.css