Fixed preserve option inside at-rules #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for the PR @muftiev 😀 Please add some tests that previously fail and now work |
Author
|
Updated tests with new cases 😄 |
Owner
|
@muftiev Let's split those off into their own |
Author
|
Ok, done) |
Author
|
@MadLittleMods Will you accept it? 😄 |
Owner
|
@muftiev Most likely, will try to get this in by Monday. Feel free to ping |
Author
|
@MadLittleMods Ping to remind you to deal with this PR |
Author
|
@MadLittleMods Really wish to use your module in my project, but I need this fix 😄 |
Owner
|
Sorry for the wait, I brushed across this tab in my browser everyday (on my mind). @muftiev Thanks again for the contribution, I'll get this onto a release pronto. |
Author
|
Thank you! |
Owner
|
@muftiev v0.5.2 now pushed to npm, https://www.npmjs.com/package/postcss-css-variables |
Author
|
Great! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42