Skip to content

Log undefined variables #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2018
Merged

Log undefined variables #69

merged 3 commits into from
Mar 22, 2018

Conversation

pixeldrew
Copy link
Contributor

@pixeldrew pixeldrew commented Mar 19, 2018 •
edited by MadLittleMods
Loading

Fix #31

Added logResultValue to log undefined variables

@pixeldrew pixeldrew mentioned this pull request Mar 19, 2018
Closed
@MadLittleMods MadLittleMods changed the title fix: 31 - Added logResolveValueResult Log undefined variables Mar 19, 2018
MadLittleMods
MadLittleMods requested changes Mar 19, 2018
View reviewed changes
Copy link
Owner

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix 🙂

We should add a test to ensure we don't regress in the future. Seems like we could assert the warnings after the plugin runs.

@MadLittleMods MadLittleMods merged commit b1702d4 into MadLittleMods:master Mar 22, 2018
@MadLittleMods
Copy link
Owner

Thanks for the contribution @pixeldrew ❤️

The fix is available in v0.8.1, https://www.npmjs.com/package/postcss-css-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pixeldrew @MadLittleMods