*undefined* problem when used value with *isImportant* option in variables. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbukum
commented
May 6, 2018
- fixed undefined problem when used value with isImportant option in variables.
MadLittleMods
requested changes
May 14, 2018
| // or we found the node | ||
| var currentNode = node; | ||
| while(currentNode.parent && !matchingNode) { | ||
| while(currentNode && currentNode.parent && !matchingNode) { |
Owner
There was a problem hiding this comment.
Let's add a test for this case so we don't regress in the future (see tests/)
Owner
|
Sorry for the delay @kbukum. Thanks for the contribution ❤️ |
Owner
|
Closing as this has sat stale for a couple months. Feel free to revive and re-open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.