Adding support for a "localsecrets" file for better auth#156
Open
klsrqm wants to merge 1 commit intoMiniGlome:mainfrom
Open
Adding support for a "localsecrets" file for better auth#156klsrqm wants to merge 1 commit intoMiniGlome:mainfrom
klsrqm wants to merge 1 commit intoMiniGlome:mainfrom
Conversation
Added a "localsecrets" file for two reasons: 1) sometimes login fails if complex passwords are provided from command line 2) it is bad practice to have to supply a password as a parameter as it ends up in shell history With these changes one can supply credentials (`user_email` and `user_password` in `localsecrets.py`), and if they are provided, the `--email` and `--password` parameters are initialised as optional. However if the parameters are supplied on command line it will override whatever is set in the `localsecrets.py` file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a "localsecrets" file for two reasons:
With these changes one can supply credentials (
user_emailanduser_passwordinlocalsecrets.py), and if they are provided, the--emailand--passwordparameters are initialised as optional. However if the parameters are supplied on command line it will override whatever is set in thelocalsecrets.pyfile.