Improve source map support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vanwagonet
commented
Dec 23, 2014
- Populate the from, to, map, and compress options from webpack info
- Pass on generated source map
| options.from = loaderUtils.getRemainingRequest(context) | ||
| options.to = loaderUtils.getRemainingRequest(context) | ||
| if (context.sourceMap) { | ||
| options.map = { inline:false, annotation:false, prev:map } |
There was a problem hiding this comment.
can you use a multiline syntax instead?
|
really nice, thanks 👍 can you just fix the little syntax issue? |
- Populate the from, to, map, and compress options from webpack info - Pass on generated source map
|
Is that the preferred style? |
|
yes, mainly for diff showing reasons. |
|
Glad I could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.