Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Add rem fallback #31

Closed
MoOx opened this issue Sep 19, 2014 · 13 comments
Closed

Add rem fallback #31

MoOx opened this issue Sep 19, 2014 · 13 comments

Comments

@MoOx
Copy link
Owner

MoOx commented Sep 19, 2014

Not sure if this should be the default behavior.
We need make something like autoprefixer to select browser support.

@MoOx
Copy link
Owner Author

MoOx commented Sep 19, 2014

Ref #32

@bloodyowl
Copy link
Contributor

why shouldn't it be the default behaviour?

@MoOx
Copy link
Owner Author

MoOx commented Sep 19, 2014

This is adding a lot of new rules. And it's only required for IE 8-.
And for one year I personnally only worked on IE9+ project.
But that why I created #32.

@bloodyowl
Copy link
Contributor

it's not that much rules, is it?

btw IE8 is actually the lowest browser many people still have to care about (i.e. http://www.quirksmode.org/blog/archives/2014/09/ie_survey_resul.html)

@MoOx
Copy link
Owner Author

MoOx commented Sep 19, 2014

It can be a lot of if you use rem a lot. For my concern it's the unit I use the most now (maybe it's not a good thing). So it can easily create between x1.5 to x2 rules.
Anyway I can make it default & use false in my case, its not a big deal. The best option will be to rely on #32.

@bloodyowl
Copy link
Contributor

yup
in most of my cases it's essentially for the grids and font-size reset after fixing the inline-block bug :)

@necolas
Copy link

necolas commented Sep 25, 2014

Probably not worth the time

@MoOx
Copy link
Owner Author

MoOx commented Nov 3, 2014

I've take a quick look to add this feature (disabled by default) using node-pixrem (based on postcss), but the plugin is not exported & use a global option (ouch). This will need a PR to make things right.
I'm also seeing an interesting issue robwierzbowski/node-pixrem#5

@necolas
Copy link

necolas commented Nov 4, 2014

It's only IE8 and Opera Mini without rem support. We don't even use fallbacks for new projects at Twitter :).

@MoOx
Copy link
Owner Author

MoOx commented Nov 4, 2014

I know, but I still have projects for client like Airbus that need IE8 support (mainly because they do not update their IT assets).
French are slow :)

@necolas
Copy link

necolas commented Nov 4, 2014

Sure. But it can just be a postcss plugin right? Does it have to be included in this project?

@MoOx
Copy link
Owner Author

MoOx commented Nov 4, 2014

I think according to the way I load plugins (by using require() only when needed), it won't create any perf issue if it's defined as dep, but not required all the time.
And for now, we can't chain cssnext with others plugins (until postcss 3 is out).
Also, we are likely to be like autoprefixer in the future, & having deps that won't be used according to the browsers (so features) list. Don't you think ?

@MoOx MoOx mentioned this issue Dec 1, 2014
@MoOx MoOx modified the milestone: v1.0.0 Dec 31, 2014
@MoOx MoOx self-assigned this Feb 2, 2015
@MoOx
Copy link
Owner Author

MoOx commented Feb 4, 2015

Now that #32 has landed in master, I will add rem and it might be disabled by default according to browserslist default.

@MoOx MoOx closed this as completed in dd46efa Feb 4, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants