Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Tests fail on fresh clone #36

Closed
necolas opened this issue Sep 25, 2014 · 5 comments
Closed

Tests fail on fresh clone #36

necolas opened this issue Sep 25, 2014 · 5 comments
Assignees

Comments

@necolas
Copy link

necolas commented Sep 25, 2014

Ran npm install then npm test and 3 tests failed:

not ok 52 should throw an error
  ---
    operator: ok
    expected: true
    actual:   null
  ...
not ok 53 should output a readable error
  ---
    operator: ok
    expected: true
    actual:   false
  ...
not ok 54 should show the url where to report bugs
  ---
    operator: ok
    expected: true
    actual:   false
  ...
@MoOx
Copy link
Owner

MoOx commented Sep 25, 2014

I've seen that a minute ago lol.
It's because of this https://github.com/substack/tap-colorize/issues/2
I'll try to fix this lib asap, or remove it everywhere :(

@necolas
Copy link
Author

necolas commented Sep 25, 2014

FWIW, I was going to make a PR to use ~ on the packages that are 0.x.x because they often have backwards incompatible changes in minor versions.

@MoOx
Copy link
Owner

MoOx commented Sep 25, 2014

Hum, I was thinking a change has been made directly in npm for this kind of issue. I'm probably wrong :/

@MoOx
Copy link
Owner

MoOx commented Sep 25, 2014

Well https://www.npmjs.org/doc/misc/semver.html#caret-ranges-1-2-3-0-2-5-0-0-4-

Allows changes that do not modify the left-most non-zero digit in the [major, minor, patch] tuple. In other words, this allows patch and minor updates for versions 1.0.0 and above, patch updates for versions 0.X >=0.1.0, and no updates for versions 0.0.X.

@necolas
Copy link
Author

necolas commented Sep 25, 2014

Oh nice. Good to know.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants