Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

watcher: always listen for change events #124

Closed
wants to merge 2 commits into from
Closed

Conversation

klaemo
Copy link

@klaemo klaemo commented May 12, 2015

watcher.on("ready") doesn't fire for multiple imports (why? I don't know!), we want to listen to changes regardless.

should fix #123

klaemo added 2 commits May 12, 2015 12:34
watcher.on("ready") doesn't fire for multiple imports (why? I don't know!), we want to listen to changes regardless.

should fix MoOx#123
@MoOx
Copy link
Owner

MoOx commented May 12, 2015

I will need more tests before merging this (even if I understand this partially fix #123)
Maybe I will switch from chokidar to gaze since I get some weird issue with it on another project too (metalsmith-watch)


If you have some time, you can work on this file https://github.com/cssnext/cssnext/blob/master/test/cli.watcher.js to reproduce the bug first, then fix it with new tests passing.

@klaemo
Copy link
Author

klaemo commented May 12, 2015

I don't think I'll have much time in the next few days unfortunately :(

@MoOx
Copy link
Owner

MoOx commented Jul 22, 2015

Closed by 9aad8a9

@MoOx MoOx closed this Jul 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watching files with multiple imports is broken
2 participants