Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

use object assign when passing options #147

Merged
merged 2 commits into from
Jun 2, 2015
Merged

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Jun 2, 2015

small fixes that avoid mutability error when passing options to atImport plugin

@MoOx
Copy link
Owner

MoOx commented Jun 2, 2015

Should be part of postcss-import plugin ? I created yesterday an issue per your comment postcss/postcss-import#43
Or we should do that for all plugin. And if a object is has been frozen, I guess Object.assign is not enough because it's only one level deep. Should be a clone... no ?

@lionelB
Copy link
Contributor Author

lionelB commented Jun 2, 2015

WTF appveyor

@MoOx
Copy link
Owner

MoOx commented Jun 2, 2015

nevermind. Thanks for updating the PR, I will merge and release soon

MoOx added a commit that referenced this pull request Jun 2, 2015
use object assign when passing options to atImport plugin
@MoOx MoOx merged commit a9dea4e into master Jun 2, 2015
@MoOx MoOx deleted the fix/import-mutability branch June 2, 2015 16:09
@MoOx
Copy link
Owner

MoOx commented Jun 2, 2015

Released as 1.6.0 !

@MoOx MoOx changed the title use object assign when passing options to atImport plugin use object assign when passing options Jun 2, 2015
@MoOx
Copy link
Owner

MoOx commented Jun 2, 2015

appveyor is happy now https://ci.appveyor.com/project/MoOx/cssnext/build/201

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants