Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Bump cssnano to v2. #166

Merged
merged 1 commit into from
Jun 29, 2015
Merged

Bump cssnano to v2. #166

merged 1 commit into from
Jun 29, 2015

Conversation

ben-eb
Copy link
Contributor

@ben-eb ben-eb commented Jun 26, 2015

cssnano 2 features built in 'quiet' removal of plugins, so disabling calc isn't necessary now.

@MoOx
Copy link
Owner

MoOx commented Jun 29, 2015

You didn't run npm test ? ;)

@ben-eb
Copy link
Contributor Author

ben-eb commented Jun 29, 2015

Oh, the trailing comma is intentional? Didn't realise. 😄

@MoOx
Copy link
Owner

MoOx commented Jun 29, 2015

the trailing comma is intentional?

yes, it's to avoid useless change in diff: you put a trailing coma all the times & do not have to think about it after.

@bloodyowl
Copy link
Contributor

@ben-eb yeah, they're nice to use for git diff, moreover they're likely to soon be tolerated in function calls https://github.com/jeffmo/es-trailing-function-commas

@ben-eb
Copy link
Contributor Author

ben-eb commented Jun 29, 2015

Looks like I need to update v2's plugin filter, at the moment the compression tests are failing. I'll write some integration tests for cssnext.

Edit: Actually, not much need. Just need to make some core optimisations PostCSS plugins instead.

@ben-eb
Copy link
Contributor Author

ben-eb commented Jun 29, 2015

Fixed up, but not passing on appveyor? 😟

@bloodyowl
Copy link
Contributor

the error seems related to wadey/node-microtime#31

@MoOx
Copy link
Owner

MoOx commented Jun 29, 2015

seems a gyp compilation issue, I won't consider this as a failure :)

MoOx added a commit that referenced this pull request Jun 29, 2015
@MoOx MoOx merged commit b71b7c8 into MoOx:master Jun 29, 2015
@ben-eb ben-eb deleted the cssnano-2 branch June 29, 2015 13:14
@magsout
Copy link
Contributor

magsout commented Jul 3, 2015

woot 👍 goood job @ben-eb

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants