Upgrade to PostCSS 5.x #209
Conversation
|
I just merged/published last requirements for updated plugins but I think we will have some issues with async plugins. cssnext default API is sync so we will run into issues. I restarted CI builds. |
48c6905 to
d481b03
Compare
|
Looks like there's an issue w/ the microtime package. I've commented on this thread: wadey/node-microtime#34 |
b980324 to
f0a1f56
Compare
664bdf2 to
d59f512
Compare
|
@MoOx it looks like AppVeyor has false positives. I'm also seeing some deprecation warnings, for which I've submitted PRs at iamvdo/pleeease-filters#12 and postcss/postcss-browser-reporter#20. The microtime commit is in reference to wadey/node-microtime#34 (comment). Lastly, it looks like Travis is exposing the issue you mentioned. What's the next step here? Or should we get started on the |
| sources: | ||
| - ubuntu-toolchain-r-test | ||
| packages: | ||
| - g++-4.8 |
There was a problem hiding this comment.
According to wadey/node-microtime#34 (comment), yes. I'd be happy to prove me wrong though. I don't like it any more than you do!
There was a problem hiding this comment.
So feel free to add a comment in the travis yml about that, so future contributors might understand what is it about (or even you in the future :D)
There was a problem hiding this comment.
I've added comments to the new microtime commit jednano@dba072a
|
@jedmao I just created a repo for postcss-cssnext https://github.com/cssnext/postcss-cssnext Here is the idea: we should extract most of the code of this repo that can be and defined postcss-cssnext as a postcss plugin. Feel free to open some issues overthere so we can iterate quickly on this. After that, we might work on a new release for cssnext based on this plugin that will bring a major breaking change in the current nodejs api. Do not hesitate if you have any question. |
00f5e40 to
dba072a
Compare
|
This won't happen. See #208. |
Fixes #202
These should be the proper version upgrades for plugins on the PostCSS 5.x path; though, a few PRs are still waiting to be merged in, so this build won't pass until they are merged and published.