Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

bump deps #333

Closed
wants to merge 1 commit into from
Closed

bump deps #333

wants to merge 1 commit into from

Conversation

haoxins
Copy link

@haoxins haoxins commented Dec 7, 2016

No description provided.

@MoOx
Copy link
Owner

MoOx commented Dec 7, 2016

The tests are failing now https://travis-ci.org/MoOx/postcss-cssnext/jobs/181888295#L1001

Can you take a look to the change and adjust the tests accordingly please?

@haoxins
Copy link
Author

haoxins commented Dec 7, 2016

submit a PR to fix the broken!

csstools/postcss-pseudo-class-any-link#6

@jonathantneal
Copy link
Collaborator

jonathantneal commented Dec 15, 2016

@coderhaoxin, @MoOx, this issue has been resolved in v3.0.1. You may want to bump the dependencies and run git commit -a --amend --date=now --no-edit && git push --force to update this pull request.

@jonathantneal jonathantneal mentioned this pull request Dec 15, 2016
@haoxins
Copy link
Author

haoxins commented Dec 16, 2016

😢 postcss-pseudo-class-any-link needs node@6+.

@jonathantneal
Copy link
Collaborator

@coderhaoxin, I’m sorry that makes you sad. Would you be able to tell me why that is?

FWIW, the current LTS for Node has been v6.9.2, and the older widely-used release (v0.12) ended support 8 months ago, with the last maintenance on it is scheduled to finish in 2 weeks (cite). All 20+ of my PostCSS plugins now require Node v6+. It has greatly improved their readability and maintainability.

@haoxins
Copy link
Author

haoxins commented Dec 20, 2016

I use node@6+, but postcss-cssnext needs support 0.12, 4, 5, 6 (according to travis.yml).

I'm +1 for dropping 0.12, 4, 5.

@MoOx
Copy link
Owner

MoOx commented Feb 1, 2017

Will drop in v3....

@chris-morgan
Copy link

chris-morgan commented May 18, 2017

postcss-pseudo-class-any-link has gone back down to node>=4 in 4.0.0.

It would be a really bad idea to drop support for Node 4 here; quite apart from Node holding 4 under LTS for another year, Ubuntu, which is probably the most popular OS for cssnext users (or at least close to it), doesn’t have anything newer than Node 4 in its package manager at present.

@jonathantneal
Copy link
Collaborator

@chris-morgan, agreed. I am bumping the dependency down in all of my plugins and have not raised it in any of my PRs to this project.

@haoxins
Copy link
Author

haoxins commented May 18, 2017

updated :)

@MoOx
Copy link
Owner

MoOx commented Jul 5, 2017

Closing in favor of #400

@MoOx MoOx closed this Jul 5, 2017
@haoxins haoxins deleted the bump-deps branch July 6, 2017 02:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants