Use PostCSS 6 and update all plugins #384

jonathantneal · 2017-05-17T21:07:26Z

This PR updates PostCSS to 6, and then updates all plugins to their latest versions.

Each test independently passes all tests. Most updates do not affect tests. All updates were purely whitespace changes except for nesting, which removes an otherwise empty parent rule which contains only nested rules. Any changes to tests are found in their corresponding commit.

Resolves #374

michael-ciniawsky

The #375 comments maybe inappropiated for now (so feel free to ignore). It could be done in another semver major release anytime and PostCSS 6 compatibility is more urgent atm 😛. Thx very much for putting this together so quickly 🎉

michael-ciniawsky · 2017-05-17T21:34:14Z

package.json

@@ -98,8 +97,9 @@
    "npmpub": "^3.1.0",
    "object-assign": "^3.0.0",


Since PostCSS 6 requires node >= 4 anyways, maybe time to get rid off that if it doesn't require to much changes 😛

Just a devDep, so doesn't really need done, but it definitely could be done.

michael-ciniawsky · 2017-05-17T21:35:04Z

package.json

    "postcss-browser-reporter": "^0.4.0",
-    "postcss-import": "^7.1.3",
+    "postcss-import": "^10.0.0",
    "postcss-loader": "^0.8.0",


Bump to v2.0.5 aswell ? 🙃

michael-ciniawsky · 2017-05-17T21:37:38Z

package.json

-    "postcss-color-function": "^2.0.0",
-    "postcss-color-gray": "^3.0.0",
-    "postcss-color-hex-alpha": "^2.0.0",
+    "pleeease-filters": "^4.0.0",


michael-ciniawsky · 2017-05-17T21:38:11Z

package.json

-    "postcss-custom-selectors": "^3.0.0",
-    "postcss-font-family-system-ui": "^1.0.1",
-    "postcss-font-variant": "^2.0.0",
+    "postcss-color-rgba-fallback": "^2.2.0",


michael-ciniawsky · 2017-05-17T21:38:31Z

package.json

-    "autoprefixer": "^6.0.2",
-    "caniuse-api": "^1.5.3",
+    "autoprefixer": "^7.1.0",
+    "caniuse-api": "^2.0.0",
    "chalk": "^1.1.1",
    "pixrem": "^3.0.0",


michael-ciniawsky · 2017-05-17T21:38:57Z

package.json

+    "postcss-media-minmax": "^3.0.0",
+    "postcss-nesting": "^3.0.0",
+    "postcss-pseudo-class-any-link": "^4.0.0",
+    "postcss-pseudoelements": "^4.0.0",


michael-ciniawsky · 2017-05-17T21:46:29Z

Travis fails because of node v0.12, better remove it from travis.yml ? 🙃

jonathantneal · 2017-05-17T23:00:11Z

Thank you for your patience. I love my company, so that always comes first! :D

@michael-ciniawsky, great catch, updated.

As for #375, I think we should merge this in before the PR becomes too big. I will make a separate PR for that.

jonathantneal · 2017-05-17T23:33:47Z

@michael-ciniawsky, @RyanZim, do not be fooled by the red X, the tests should have passed. 😄

It looks like the last test failed to initialize; see: https://ci.appveyor.com/project/MoOx/postcss-cssnext/build/85/job/0iinwm41xjcwjftk

Could someone re-run it?

Semigradsky · 2017-05-18T08:31:58Z

Hi @jonathantneal! Could you change base to 3.0 branch?

- Updates tests for whitespacing, which PostCSS 6 captures more accurately.

No test changes required

One test is changed because `@apply` changes how nested spacing is handled.

No test changes required

No test changes needed

No text changes needed

No test changes needed

To test changes needed

No test changes needed

One test changes, as an rgb rebeccapurple compiles to a shorter hex version

No test changes needed

Nesting 3 removes unnecessary parents and normalizes spacing (similar to the new apply)

No testing changes needed

PostCSS no longer supports v0.12

jonathantneal · 2017-05-18T14:20:57Z

@Semigradsky, yes, I have rebased against 3.0 and updated the base of this PR.

jonathantneal · 2017-05-23T21:08:38Z

@Semigradsky, ping?

jonathantneal · 2017-05-24T13:42:25Z

With these approved, once these are in, we can pull in any additional plugin updates that have come in since this was opened.

Semigradsky · 2017-05-25T15:16:23Z

I see that there are two problems left that prevent us from releasing a new version.

The future of nesting and @apply. We will remove them from the new version? I did not see the final decision. ping @MoOx
The future of unmaintained plugins. We send PR but no any reaction. ping @MattDiMu
We can forked these repositories and publish to npm for new names.

jonathantneal · 2017-05-25T15:27:03Z

@Semigradsky, I think starting with getting this in is a big first step. Then...

CSS @apply is actively abandoned/disliked by the creator and should be removed. Citation from author: http://www.xanthir.com/b4o00
CSS Nesting is merely in the backlog, along with a handful of other specs; lacking the interest/focus to move them ahead. It should remain. Citation from author: https://twitter.com/tabatkins/status/862409545489895424

dmarchena · 2017-05-25T16:40:56Z

Sorry @Semigradsky, I didn't see your PRs. I've just accepted them and published new versions for postcss-color-rgb and postcss-color-hsl.

jonathantneal · 2017-05-30T12:47:06Z

cssnext is now so out of date, I am just using a local package, because I otherwise deal with a lot of bugs that people think means the plugins are still broken. For those who need this, it’s:

require('postcss-custom-properties')(),
require('postcss-apply')(),
require('postcss-image-set-polyfill')(),
require('postcss-nesting')(),
require('postcss-custom-media')(),
require('postcss-media-minmax')(),
require('postcss-custom-selectors')(),
require('postcss-attribute-case-insensitive')(),
require('postcss-color-rebeccapurple')(),
require('postcss-color-hwb')(),
require('postcss-color-hsl')(),
require('postcss-color-rgb')(),
require('postcss-color-gray')(),
require('postcss-color-hex-alpha')(),
require('postcss-color-function')(),
require('postcss-font-family-system-ui')(),
require('postcss-font-variant')(),
require('postcss-initial')(),
require('postcss-selector-matches')(),
require('postcss-selector-not')(),
require('postcss-pseudo-class-any-link')(),
require('postcss-replace-overflow-wrap')(),

All of these aforementioned plugins are now working with PostCSS 6x.

francoisromain · 2017-06-02T08:13:20Z

@jonathantneal just to understand, could you list what is out of date in cssnext, please?

Semigradsky · 2017-06-02T08:53:53Z

@jonathantneal could you update dependencies and remove @apply?
I see that this is all that remains to be done before the merge.

jonathantneal · 2017-06-02T20:53:22Z

@Semigradsky, it would be easier to redo this in #385

Are we removing the non-future plugins? Or are they already gone?

Semigradsky · 2017-06-03T07:02:14Z

it would be easier to redo this in #385

No problem. Then it remains only to update the plugins.
postcss-color-hsl, postcss-replace-overflow-wrap, etc.

doochik · 2017-06-05T12:26:41Z

All plugins are released. Can you update PR?

jaap3 · 2017-06-06T13:27:16Z

package.json

-    "postcss-pseudo-class-any-link": "^1.0.0",
+    "postcss-initial": "^2.0.0",
+    "postcss-media-minmax": "^3.0.0",
+    "postcss-nesting": "^3.0.0",


The most recent version of postcss-nesting is 4.0.1

Kurre

Quickly reviewed all dependencies and commented on those which should/could be bumbed up.

It seems that only outdated package is postcss-browser-reporter (if I didn't miss anything).

Hopefully this helps maintainers a bit :)

Kurre · 2017-06-13T09:39:57Z

package.json

+    "postcss-calc": "^6.0.0",
+    "postcss-color-function": "^4.0.0",
+    "postcss-color-gray": "^4.0.0",
+    "postcss-color-hex-alpha": "^3.0.0",
    "postcss-color-hsl": "^1.0.5",


PostCSS v6 support with ^2.0.0

Kurre · 2017-06-13T09:40:43Z

package.json

-    "postcss-color-hwb": "^2.0.0",
-    "postcss-color-rebeccapurple": "^2.0.0",
+    "postcss-color-hwb": "^3.0.0",
+    "postcss-color-rebeccapurple": "^3.0.0",
    "postcss-color-rgb": "^1.1.4",


PostCSS v6 support with ^2.0.0

Kurre · 2017-06-13T09:41:02Z

package.json

+    "postcss-custom-properties": "^6.0.1",
+    "postcss-custom-selectors": "^4.0.1",
+    "postcss-font-family-system-ui": "^2.0.1",
+    "postcss-font-variant": "^3.0.0",
    "postcss-image-set-polyfill": "^0.3.3",


PostCSS v6 support with ^0.3.5

Kurre · 2017-06-13T09:43:14Z

package.json

+    "postcss-initial": "^2.0.0",
+    "postcss-media-minmax": "^3.0.0",
+    "postcss-nesting": "^3.0.0",
+    "postcss-pseudo-class-any-link": "^4.0.0",
    "postcss-replace-overflow-wrap": "^1.0.0",


PostCSS v6 support with ^2.0.0

Kurre · 2017-06-13T09:52:38Z

package.json

@@ -95,8 +94,9 @@
    "npmpub": "^3.1.0",
    "object-assign": "^3.0.0",
    "opn": "^1.0.2",
+    "postcss-apply": "^0.7.0",


Can be bumbed to ^0.8.0

Kurre · 2017-06-13T09:59:29Z

package.json

@@ -95,8 +94,9 @@
    "npmpub": "^3.1.0",
    "object-assign": "^3.0.0",
    "opn": "^1.0.2",
+    "postcss-apply": "^0.7.0",
    "postcss-browser-reporter": "^0.4.0",


Missing PostCSS v6 support

Kurre · 2017-06-13T10:01:11Z

package.json

    "postcss-browser-reporter": "^0.4.0",
-    "postcss-import": "^7.1.3",
+    "postcss-import": "^10.0.0",
    "postcss-loader": "^0.8.0",


PostCSS v6 support with ^2.0.5

Kurre · 2017-06-13T10:01:22Z

package.json

    "postcss-browser-reporter": "^0.4.0",
-    "postcss-import": "^7.1.3",
+    "postcss-import": "^10.0.0",
    "postcss-loader": "^0.8.0",
    "postcss-reporter": "^1.3.0",


PostCSS v6 support with ^4.0.0

Kurre · 2017-06-13T10:01:58Z

package.json

    "postcss-browser-reporter": "^0.4.0",
-    "postcss-import": "^7.1.3",
+    "postcss-import": "^10.0.0",
    "postcss-loader": "^0.8.0",
    "postcss-reporter": "^1.3.0",
    "postcss-url": "^5.0.2",


PostCSS v6 support with ^7.0.0

longlho · 2017-06-26T15:47:45Z

hi guys, any progress on this?

shouze · 2017-06-28T10:23:12Z

@jonathantneal do you have some time to integrate @Kurre & @jaap3 feedbacks? So close to merge as appveyor failure looks like a false positive.

jonathantneal · 2017-06-29T18:15:13Z

I don’t. This should have been merged when it was relevant.

MoOx · 2017-07-03T13:50:49Z

Why is this not remevant anymore?

shouze · 2017-07-03T13:54:29Z

Yes, I also want to know why (because I've asked Norah Jones and she don't know why 🎵 )

MoOx · 2017-07-03T14:34:55Z

Now that all deps are ready, it should be done until a better solution is ready...

shouze · 2017-07-03T15:10:23Z

@MoOx would you mind if I reopen this PR & adapt last things to get it merged ASAP?

longlho · 2017-07-03T15:11:22Z

@shouze I opened another one #398

MoOx · 2017-07-03T15:16:25Z

Just got back from long vacations so have a tons of stuff to handle but I will do my best...

MoOx · 2017-07-04T13:59:46Z

See #400 for current WIP.

jonathantneal mentioned this pull request May 17, 2017

Upgrade to postcss 6.x #374

Closed

michael-ciniawsky approved these changes May 17, 2017

View reviewed changes

jonathantneal mentioned this pull request May 17, 2017

Only use "future" plugins #385

Closed

jonathantneal changed the base branch from master to 3.0 May 18, 2017 13:04

jonathantneal added 19 commits May 18, 2017 09:05

Use PostCSS 6

b0db778

- Updates tests for whitespacing, which PostCSS 6 captures more accurately.

Use PostCSS Import 10

5b95330

No test changes required

Use PostCSS Apply 0.7

e1c444a

One test is changed because `@apply` changes how nested spacing is handled.

Use Autoprefixer 7

e48261b

No test changes required

Use CanIUse API 2

9ba1169

No test changes needed

Use Please Filters 3.0.1

e29c53c

No text changes needed

Use Attribute Case Insensitive 2

a8077cf

No test changes needed

Use Please Filters 4

7f45425

To test changes needed

Use Calc 6

e0f3e62

No test changes needed

Use latest Color plugins

bd5571f

One test changes, as an rgb rebeccapurple compiles to a shorter hex version

Use latest Custom plugins

b952973

No test changes needed

Use latest Text plugins

702a92d

No test changes needed

Use Initial 2

c36b858

No test changes needed

Use Media MinMax 3

1cc3d5d

No test changes needed

Use Nesting 3

2221d70

Nesting 3 removes unnecessary parents and normalizes spacing (similar to the new apply)

Use Pseudo Class Any Link 4

2a26ea4

No testing changes needed

Use Selector Matches 3

21c8db9

No testing changes needed

Use Selector Not 3

bf9ff4b

No testing changes needed

Update .travis.yml and .appveyor.yml for Node v4 compatibility

68e759f

PostCSS no longer supports v0.12

michael-ciniawsky mentioned this pull request May 19, 2017

Node#before is deprecated. Use Node#raws.before postcss/postcss-import#286

Closed

RyanZim approved these changes May 23, 2017

View reviewed changes

Semigradsky mentioned this pull request Jun 3, 2017

Use PostCSS 6 #383

Closed

jaap3 reviewed Jun 6, 2017

View reviewed changes

Kurre suggested changes Jun 13, 2017

View reviewed changes

HerrBertling mentioned this pull request Jun 22, 2017

Proposal: Use separate postcss packages instead of postcss-cssnext xing/hops#169

Closed

jonathantneal closed this Jun 29, 2017

MoOx mentioned this pull request Jul 4, 2017

Postcss6 upgrade #400

Merged

		@@ -98,8 +97,9 @@
		"npmpub": "^3.1.0",
		"object-assign": "^3.0.0",

Uh oh!

Use PostCSS 6 and update all plugins #384

Use PostCSS 6 and update all plugins #384

Uh oh!

Conversation

jonathantneal commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michael-ciniawsky left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky commented May 17, 2017

Uh oh!

jonathantneal commented May 17, 2017

Uh oh!

jonathantneal commented May 17, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Semigradsky commented May 18, 2017

Uh oh!

jonathantneal commented May 18, 2017

Uh oh!

jonathantneal commented May 23, 2017

Uh oh!

jonathantneal commented May 24, 2017

Uh oh!

Semigradsky commented May 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonathantneal commented May 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmarchena commented May 25, 2017

Uh oh!

jonathantneal commented May 30, 2017

Uh oh!

francoisromain commented Jun 2, 2017

Uh oh!

Semigradsky commented Jun 2, 2017

Uh oh!

jonathantneal commented Jun 2, 2017

Uh oh!

Semigradsky commented Jun 3, 2017

Uh oh!

doochik commented Jun 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kurre left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

jonathantneal commented May 17, 2017 •

edited

Loading

michael-ciniawsky left a comment •

edited

Loading

jonathantneal commented May 17, 2017 •

edited

Loading

Semigradsky commented May 25, 2017 •

edited

Loading

jonathantneal commented May 25, 2017 •

edited

Loading

Kurre left a comment •

edited

Loading