Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

First pass at integrating postcss-url into cssnext #62

Merged
merged 1 commit into from
Jan 28, 2015
Merged

First pass at integrating postcss-url into cssnext #62

merged 1 commit into from
Jan 28, 2015

Conversation

jasonkuhrt
Copy link
Contributor

This will close #55 #57 .

@MoOx Please review the change.

  1. What other tests do we need? We shouldn't be testing postcss-url but just its integration into cssnext. At this time I already feel like the existing test should be covered by postcss-url proper; but at least this gets us going to prove integration is working.
  2. I modified the code-base ever so slightly, most of all the test runner for features since we need to couple the url and import features.

@jasonkuhrt
Copy link
Contributor Author

Pardon me, this PR will close #57, _not_ #55 which is already closed.

@MoOx
Copy link
Owner

MoOx commented Jan 28, 2015

I will probably change the tests to get standalone tests (I think I can make something which is not turning import on to test url integration) but it's a good start. Thanks.

MoOx added a commit that referenced this pull request Jan 28, 2015
First pass at integrating postcss-url into cssnext
@MoOx MoOx merged commit b59c9da into MoOx:master Jan 28, 2015
@jasonkuhrt jasonkuhrt deleted the feature/add-postcss-url branch January 28, 2015 12:51
@jasonkuhrt
Copy link
Contributor Author

@MoOx Pleasure! Sounds good.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants