Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

Add config option to CLI #74

Merged
merged 3 commits into from
Mar 5, 2015
Merged

Add config option to CLI #74

merged 3 commits into from
Mar 5, 2015

Conversation

hgl
Copy link

@hgl hgl commented Feb 27, 2015

Feel free to change the flag name and the input & output options in the config file.

@MoOx
Copy link
Owner

MoOx commented Feb 27, 2015

I would more like to see a PR that cover cli and non cli usage ( #73)

@MoOx
Copy link
Owner

MoOx commented Feb 27, 2015

Note: input and output do not have their place in a generic config file

@hgl
Copy link
Author

hgl commented Feb 27, 2015

#73 looks like it belongs to another commit. This PR simply allows users to specify a config flag. Also you haven't settled on the file name in that issue.

cli usage is covered in the unit tests.

I will remove input and output from the config file.

@hgl
Copy link
Author

hgl commented Feb 27, 2015

Done. (it seems appveyor failed to install microtime, not sure how that happened.)

@MoOx
Copy link
Owner

MoOx commented Mar 3, 2015

Can you also include documentation and a line in the changelog for that (as # Unreleased) ?
Thanks !

@hgl
Copy link
Author

hgl commented Mar 3, 2015

Changelog updated. By documentation do you mean the readme file? It already contains the To see all CLI options section, not sure where to add the doc. Should I add a section to specifically explain the config option?

@MoOx
Copy link
Owner

MoOx commented Mar 3, 2015

Good point !
I will handle that from here :)
Thanks a lot.

@hgl
Copy link
Author

hgl commented Mar 3, 2015

Thank you for accepting the PR. :)

MoOx added a commit that referenced this pull request Mar 5, 2015
Add `config` option to CLI
@MoOx MoOx merged commit 653b25a into MoOx:master Mar 5, 2015
@MoOx
Copy link
Owner

MoOx commented Mar 5, 2015

Released in 1.1.0

@hgl
Copy link
Author

hgl commented Mar 5, 2015

👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants