Rewrite #21
Closed
Rewrite #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoOx
requested changes
Mar 1, 2017
There was a problem hiding this comment.
not sure it's a good idea to have postcss as a dep for a non postcss project... (I had in mind that other stuff like rework might use it).
If that's too postcss related why not merging this with postcss-calc directly?
Also it seems you don't cover all previous tests with the new tests so regressions are possible. Any reason to not keep previous tests in addition to new ones?
.babelrc
Outdated
| @@ -0,0 +1,12 @@ | |||
| { | |||
| "presets": ["es2015-loose", "stage-0"], | |||
| @@ -0,0 +1,86 @@ | |||
| --- | |||
There was a problem hiding this comment.
package.json
Outdated
| "files": [ | ||
| "index.js" | ||
| "dist", | ||
| "LICENSE" |
There was a problem hiding this comment.
LICENSE is unecessary and automatic like README
|
@MoOx it's not dependent upon postcss. It might just be some leftover copypasta from the postcss-calc rewrite. I'll fix it when I get home from work. |
Merged
|
#22 supersedes this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrite is done with the intent of fixing inconsistent behaviour between reduce-css-calc and the W3C specification, as well as enabling better optimisation of
calc()expressions. The rewrite is done from the ground-up in ES6 while still staying compatible with the existing API. It reducescalc()functions by transforming ASTs generated from the expressions.The rewrite also solves the following issues: