Skip to content

Fix calc being partially matched to a different function signature #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix calc being partially matched to a different function signature #31

wants to merge 1 commit into from

Conversation

andyjansson
Copy link
Contributor

No description provided.

@MoOx MoOx requested a review from ben-eb August 14, 2017 07:32
@MoOx
Copy link
Owner

MoOx commented Sep 19, 2017

@ben-eb is this ok for you?

@MoOx MoOx mentioned this pull request Sep 19, 2017
Closed
@lkraav
Copy link

lkraav commented Sep 19, 2017

@MoOx I think I manually patched this in, and found no ill effects. Regex change seems quite safe and simple in nature, too.

ben-eb
ben-eb requested changes Sep 19, 2017
View reviewed changes
Copy link
Collaborator

@ben-eb ben-eb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also make this regex case-insensitive, it's a legitimate use-case. Otherwise, looks good. 👍

@MoOx MoOx deleted the branch MoOx:master July 2, 2024 10:42
@MoOx MoOx closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-eb ben-eb ben-eb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyjansson @MoOx @lkraav @ben-eb