jison: switch to maintained fork #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could this be released as a patch? Or should this be a breaking change? |
|
Hi @MoOx - This should not affect users at all. Tests are passing -- patch should be fine. |
|
Any news on merging and releasing this patch? |
MoOx
approved these changes
Oct 22, 2019
|
2.1.7 is out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @MoOx, thanks for this library!
I see that you're already using a custom fork of jison -- we are having issues downstream due to the
main()function added to the end ofparser.jsby jison (for command-line usability -- itrequire()s thefsmodule, which doesn't exist in our build environment).There are quite a few dangling PRs in the main jison repo, but this one is pretty active & maintained:
https://github.com/GerHobbelt/jison
available on npm: https://www.npmjs.com/package/jison-gho
I was considering creating my own fork, but I'd rather go with the community if possible.
Looks like the tests are all still passing -- hopefully this fork also addresses the use-cases that lead to you going off-package as well.