ResizeSensor.js optimization (marcj#172)

FranckFreiburger · marcj · commit 85122fe77f91 · 2017-06-09T18:56:37.000+02:00
The aim of `getComputedStyle(element, 'position') == 'static'` is to detect that `element` is not "positioned". [`HTMLElement.offsetParent`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent) returns the nearest positioned element in the containment hierarchy. `element.resizeSensor.offsetParent !== element` mean that `element` is not positioned. Right ?
diff --git a/src/ResizeSensor.js b/src/ResizeSensor.js
@@ -92,22 +92,6 @@
             }
         }
 
-        /**
-         * @param {HTMLElement} element
-         * @param {String}      prop
-         * @returns {String|Number}
-         */
-        function getComputedStyle(element, prop) {
-            if (element.currentStyle) {
-                return element.currentStyle[prop];
-            }
-            if (window.getComputedStyle) {
-                return window.getComputedStyle(element, null).getPropertyValue(prop);
-            }
-
-            return element.style[prop];
-        }
-
         /**
          *
          * @param {HTMLElement} element
@@ -138,7 +122,7 @@
                 '</div>';
             element.appendChild(element.resizeSensor);
 
-            if (getComputedStyle(element, 'position') == 'static') {
+            if (element.resizeSensor.offsetParent !== element) {
                 element.style.position = 'relative';
             }
 
