ResizeSensor.js optimization #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aim of `getComputedStyle(element, 'position') == 'static'` is to detect that `element` is not "positioned". [`HTMLElement.offsetParent`](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent) returns the nearest positioned element in the containment hierarchy. `element.resizeSensor.offsetParent !== element` mean that `element` is not positioned. Right ?
|
Very clever, thanks! |
jccr
pushed a commit
to readium/readium-shared-js
that referenced
this pull request
Sep 15, 2017
…able doc to be "positioned" The third-party ResizeSensor module wants to set its target element's `position` style to be `relative` as it is key to its functionality. Unfortunately the condition that checked for this no longer applies to our usage's target element being the 'body'. It used to check the target element's computed style for position, see if it’s `static` and then change it to `relative`. As of this patch it no longer does the check in the same way: marcj/css-element-queries#172 Now it checks the ‘offsetParent’ property of the resize sensor container element, if the offsetParent is not the target element then it applies the ‘relative’ value. From what I’ve seen by inspecting things with Chrome, looking at the live DOM of the content documents, even if the body has ‘relative’ or not, it by default is the ‘offsetParent’ of the resize sensor element. This means that after this merge the 'position: relative’ that’s needed is no longer applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of
getComputedStyle(element, 'position') == 'static'is to detect thatelementis not "positioned".HTMLElement.offsetParentreturns the nearest positioned element in the containment hierarchy.element.resizeSensor.offsetParent !== elementmean thatelementis not positioned.(see issue #164)
Right ?