Appended rows now get run through the column converter#4
Merged
Iodine- merged 1 commit intoMoveInc:masterfrom Nov 3, 2016
Merged
Appended rows now get run through the column converter#4Iodine- merged 1 commit intoMoveInc:masterfrom
Iodine- merged 1 commit intoMoveInc:masterfrom
Conversation
Author
|
Logic is the same as the loadRows function: https://github.com/MoveInc/jquery-bootgrid/blob/master/src/internal.js#L256-L258 |
|
@awestbro This looks great. Looks like it may resolve rstaib#300, rstaib#258, rstaib#267 which is great! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an with appended rows not being interpreted by the column converter. In our case, we would append string numbers (e.x. "100") with the "number" formatter and "numeric" converter. When you would append the row, the value would be put in the rows as a string which was formatted correctly, but it treated the row as a string sort.