[TASK] Add native type declarations for CSSList (#1181)

Part of #811

Author: oliverklee

CHANGELOG.md

@@ -34,7 +34,7 @@ Please also have a look at our
 - Use more native type declarations and strict mode
   (#641, #772, #774, #778, #804, #841, #873, #875, #891, #922, #923, #933, #958,
   #964, #967, #1000, #1044, #1134, #1136, #1137, #1139, #1140, #1141, #1145,
-  #1162, #1163, #1166, #1172, #1174, #1178, #1179)
+  #1162, #1163, #1166, #1172, #1174, #1178, #1179, #1181)
 - Add visibility to all class/interface constants (#469)
 
 ### Deprecated

src/CSSList/CSSList.php

@@ -41,7 +41,7 @@ abstract class CSSList implements Renderable, Commentable
     protected $comments = [];
 
     /**
-     * @var array<int, RuleSet|CSSList|Import|Charset>
+     * @var array<int<0, max>, RuleSet|CSSList|Import|Charset>
      *
      * @internal since 8.8.0
      */
@@ -283,11 +283,9 @@ public function append($item): void
     /**
      * Splices the list of contents.
      *
-     * @param int $offset
-     * @param int $length
      * @param array<int, RuleSet|CSSList|Import|Charset> $replacement
      */
-    public function splice($offset, $length = null, $replacement = null): void
+    public function splice(int $offset, ?int $length = null, ?array $replacement = null): void
     {
         \array_splice($this->contents, $offset, $length, $replacement);
     }
@@ -317,13 +315,14 @@ public function insertBefore($item, $sibling): void
      *
      * @return bool whether the item was removed
      */
-    public function remove($itemToRemove)
+    public function remove($itemToRemove): bool
     {
         $key = \array_search($itemToRemove, $this->contents, true);
         if ($key !== false) {
             unset($this->contents[$key]);
             return true;
         }
+
         return false;
     }
 
@@ -333,10 +332,9 @@ public function remove($itemToRemove)
      * @param RuleSet|Import|Charset|CSSList $oldItem
      *        May be a `RuleSet` (most likely a `DeclarationBlock`), an `Import`, a `Charset`
      *        or another `CSSList` (most likely a `MediaQuery`)
-     *
-     * @return bool
+     * @param RuleSet|Import|Charset|CSSList|array<RuleSet|Import|Charset|CSSList> $newItem
      */
-    public function replace($oldItem, $newItem)
+    public function replace($oldItem, $newItem): bool
     {
         $key = \array_search($oldItem, $this->contents, true);
         if ($key !== false) {
@@ -347,6 +345,7 @@ public function replace($oldItem, $newItem)
             }
             return true;
         }
+
         return false;
     }
 
@@ -364,10 +363,10 @@ public function setContents(array $contents): void
     /**
      * Removes a declaration block from the CSS list if it matches all given selectors.
      *
-     * @param DeclarationBlock|array<array-key, Selector>|string $selectors the selectors to match
+     * @param DeclarationBlock|array<Selector>|string $selectors the selectors to match
      * @param bool $removeAll whether to stop at the first declaration block found or remove all blocks
      */
-    public function removeDeclarationBlockBySelector($selectors, $removeAll = false): void
+    public function removeDeclarationBlockBySelector($selectors, bool $removeAll = false): void
     {
         if ($selectors instanceof DeclarationBlock) {
             $selectors = $selectors->getSelectors();
@@ -436,17 +435,15 @@ protected function renderListContents(OutputFormat $outputFormat): string
 
     /**
      * Return true if the list can not be further outdented. Only important when rendering.
-     *
-     * @return bool
      */
-    abstract public function isRootList();
+    abstract public function isRootList(): bool;
 
     /**
      * Returns the stored items.
      *
-     * @return array<int, RuleSet|Import|Charset|CSSList>
+     * @return array<int<0, max>, RuleSet|Import|Charset|CSSList>
      */
-    public function getContents()
+    public function getContents(): array
     {
         return $this->contents;
     }