Skip to content

Add native type declarations #811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
47 tasks done
oliverklee opened this issue Jan 25, 2025 · 1 comment
Closed
47 tasks done

Add native type declarations #811

oliverklee opened this issue Jan 25, 2025 · 1 comment
Assignees

Comments

@oliverklee
Copy link
Collaborator

oliverklee commented Jan 25, 2025

… as far as possible with PHP 7.2.

  • ├── Comment
  • │   ├── Commentable.php
  • │   └── Comment.php
  • ├── CSSList
  • │   ├── AtRuleBlockList.php
  • │   ├── CSSBlockList.php
  • │   ├── CSSList.php
  • │   ├── Document.php
  • │   └── KeyFrame.php
  • ├── OutputFormat.php
  • ├── OutputFormatter.php
  • ├── Parser.php
  • ├── Parsing
  • │   ├── Anchor.php
  • │   ├── OutputException.php
  • │   ├── ParserState.php
  • │   ├── SourceException.php
  • │   ├── UnexpectedEOFException.php
  • │   └── UnexpectedTokenException.php
  • ├── Property
  • │   ├── AtRule.php
  • │   ├── Charset.php
  • │   ├── CSSNamespace.php
  • │   ├── Import.php
  • │   ├── KeyframeSelector.php
  • │   └── Selector.php
  • ├── Renderable.php
  • ├── Rule
  • │   └── Rule.php
  • ├── RuleSet
  • │   ├── AtRuleSet.php
  • │   ├── DeclarationBlock.php
  • │   └── RuleSet.php
  • ├── Settings.php
  • └── Value
  • ├── CalcFunction.php
  • ├── CalcRuleValueList.php
  • ├── Color.php
  • ├── CSSFunction.php
  • ├── CSSString.php
  • ├── LineName.php
  • ├── PrimitiveValue.php
  • ├── RuleValueList.php
  • ├── Size.php
  • ├── URL.php
  • ├── ValueList.php
  • └── Value.php
@oliverklee oliverklee self-assigned this Jan 25, 2025
oliverklee added a commit that referenced this issue Jan 26, 2025
Also make one condition more strict (via Rector).

Part of #811
oliverklee added a commit that referenced this issue Jan 27, 2025
Also make one condition more strict (via Rector).

Part of #811
oliverklee added a commit that referenced this issue Jan 27, 2025
Also make one condition more strict (via Rector).

Part of #811
oliverklee added a commit that referenced this issue Feb 14, 2025
Also improve the type annotations.

Also fix the callers to get the tests green with the native types.

Part of #811
oliverklee added a commit that referenced this issue Mar 17, 2025
Also add some more type checks to ensure that the corresponding
types are actually returned.

Part of #811
JakeQZ pushed a commit that referenced this issue Mar 17, 2025
Also add some more type checks to ensure that the corresponding
types are actually returned.

Part of #811
oliverklee added a commit that referenced this issue Mar 17, 2025
oliverklee added a commit that referenced this issue Mar 17, 2025
JakeQZ pushed a commit that referenced this issue Mar 17, 2025
JakeQZ pushed a commit that referenced this issue Mar 18, 2025
oliverklee added a commit that referenced this issue Mar 18, 2025
oliverklee added a commit that referenced this issue Mar 18, 2025
JakeQZ pushed a commit that referenced this issue Mar 18, 2025
oliverklee added a commit that referenced this issue Mar 18, 2025
JakeQZ pushed a commit that referenced this issue Mar 18, 2025
oliverklee added a commit that referenced this issue Mar 19, 2025
Also polish some PHPDoc type annotations.

Part of #811.
JakeQZ pushed a commit that referenced this issue Mar 19, 2025
Also polish some PHPDoc type annotations.

Part of #811.
oliverklee added a commit that referenced this issue Mar 20, 2025
Also make some types more specific. Also improve code
formatting a bit.

Part of #811
JakeQZ pushed a commit that referenced this issue Mar 20, 2025
Also make some types more specific. Also improve code
formatting a bit.

Part of #811
@oliverklee
Copy link
Collaborator Author

All done. 🥳 Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant