-
Notifications
You must be signed in to change notification settings - Fork 144
Drop support for older PHP versions #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
And in https://github.com/MyIntervals/emogrifier, we'd like to use this library. Our next major release will still support PHP 7.2, so PHP-CSS-Parser still supporting PHP 7.2 will be helpful. |
As I commented at #206 (comment), updating the PHP requirement detrimental for WordPress which still supports PHP 5.6. If PHPDoc can be used until WordPress increases the minimum, this would be ideal. Otherwise, the dozens of WordPress plugins that use PHP-CSS-Parser would be forced to fork the package. |
Then I propose we start with raising the minimum required PHP version to 5.6. What do you think? |
Yes, that works for me! |
Okay then, 5.6.20 it is (which are the current WordPress PHP requirements). I will create a PR after some of my other PRs are merged. |
Now the PHP version requirement is on par with WordPress. Fixes MyIntervals#207
Now the PHP version requirement is on par with WordPress: https://wordpress.org/support/article/requirements/ Fixes MyIntervals#207
Now the PHP version requirement is on par with WordPress: https://wordpress.org/support/article/requirements/ Fixes MyIntervals#207
Now the PHP version requirement is on par with WordPress: https://wordpress.org/support/article/requirements/ Fixes MyIntervals#207
Now the PHP version requirement is on par with WordPress: https://wordpress.org/support/article/requirements/ Fixes MyIntervals#207
I propose this library drops support for older PHP versions so it can use newer PHP features.
According to https://www.php.net/supported-versions.php, PHP 7.2 recently reached its end of life. So I propose to drop support for all PHP versions < 7.2.
(We then can use Rector to upgrade the code accordingly.)
What do you think?
The text was updated successfully, but these errors were encountered: