Skip to content

Drop support for older PHP versions #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverklee opened this issue Apr 18, 2021 · 5 comments · Fixed by #215
Closed

Drop support for older PHP versions #207

oliverklee opened this issue Apr 18, 2021 · 5 comments · Fixed by #215

Comments

@oliverklee
Copy link
Collaborator

I propose this library drops support for older PHP versions so it can use newer PHP features.

According to https://www.php.net/supported-versions.php, PHP 7.2 recently reached its end of life. So I propose to drop support for all PHP versions < 7.2.

(We then can use Rector to upgrade the code accordingly.)

What do you think?

@oliverklee
Copy link
Collaborator Author

And in https://github.com/MyIntervals/emogrifier, we'd like to use this library. Our next major release will still support PHP 7.2, so PHP-CSS-Parser still supporting PHP 7.2 will be helpful.

@westonruter
Copy link
Collaborator

As I commented at #206 (comment), updating the PHP requirement detrimental for WordPress which still supports PHP 5.6. If PHPDoc can be used until WordPress increases the minimum, this would be ideal. Otherwise, the dozens of WordPress plugins that use PHP-CSS-Parser would be forced to fork the package.

@oliverklee
Copy link
Collaborator Author

Then I propose we start with raising the minimum required PHP version to 5.6. What do you think?

@westonruter
Copy link
Collaborator

Yes, that works for me!

@oliverklee
Copy link
Collaborator Author

Okay then, 5.6.20 it is (which are the current WordPress PHP requirements). I will create a PR after some of my other PRs are merged.

oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue Apr 25, 2021
Now the PHP version requirement is on par with WordPress.

Fixes MyIntervals#207
oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue Apr 25, 2021
Now the PHP version requirement is on par with WordPress:
https://wordpress.org/support/article/requirements/

Fixes MyIntervals#207
oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue Apr 30, 2021
Now the PHP version requirement is on par with WordPress:
https://wordpress.org/support/article/requirements/

Fixes MyIntervals#207
oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue May 3, 2021
Now the PHP version requirement is on par with WordPress:
https://wordpress.org/support/article/requirements/

Fixes MyIntervals#207
raxbg pushed a commit to raxbg/PHP-CSS-Parser that referenced this issue Sep 15, 2022
Now the PHP version requirement is on par with WordPress:
https://wordpress.org/support/article/requirements/

Fixes MyIntervals#207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants