Skip to content

Flatten the production code directory structure #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue May 28, 2021 · 1 comment · Fixed by #236
Closed

Flatten the production code directory structure #230

oliverklee opened this issue May 28, 2021 · 1 comment · Fixed by #236

Comments

@oliverklee
Copy link
Collaborator

To be more consistent with most other PHP projects, I'd like to change the directory structure like this (without changing the namespaces of the PHP classes):

lib/Sabberworm/CSS/*.php -> src/*.php

@sabberworm @westonruter Would this be okay for you?
@sabberworm
Copy link
Collaborator

Sounds good, thanks

oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue May 30, 2021
@oliverklee
Move the production code from lib/ to src/
91d0d54 
This gets the directory structure more in line with what most
other projects (including Symfony) are using. (The PHP namespaces
are unchanged, though.)

Also flatten the directory structure.

Fixes MyIntervals#230
@oliverklee oliverklee mentioned this issue May 30, 2021
Merged
oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue Jun 1, 2021
@oliverklee
Move the production code from lib/ to src/
43981c9 
This gets the directory structure more in line with what most
other projects (including Symfony) are using. (The PHP namespaces
are unchanged, though.)

Also flatten the directory structure.

Fixes MyIntervals#230
oliverklee added a commit to oliverklee/PHP-CSS-Parser that referenced this issue Jun 2, 2021
@oliverklee
Move the production code from lib/ to src/
9e2107e 
This gets the directory structure more in line with what most
other projects (including Symfony) are using. (The PHP namespaces
are unchanged, though.)

Also flatten the directory structure.

Fixes MyIntervals#230
raxbg pushed a commit to raxbg/PHP-CSS-Parser that referenced this issue Sep 15, 2022
@oliverklee @raxbg
Move the production code from lib/ to src/
cd45cf1 
This gets the directory structure more in line with what most
other projects (including Symfony) are using. (The PHP namespaces
are unchanged, though.)

Also flatten the directory structure.

Fixes MyIntervals#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move the production code from lib/ to src/ oliverklee/PHP-CSS-Parser
2 participants
@sabberworm @oliverklee