Skip to content

[href=https://example.org] selector is discarded #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JakeQZ opened this issue Dec 14, 2021 · 4 comments
Closed

[href=https://example.org] selector is discarded #347

JakeQZ opened this issue Dec 14, 2021 · 4 comments

Comments

@JakeQZ
Copy link
Collaborator

JakeQZ commented Dec 14, 2021

This is a BC issue following #162.

Maybe the regex can be fixed, or maye a different approach is needed.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Dec 14, 2021

Note this is using the selector [href=https://example.org] as written. AFAIK there is no requirement for the value to be quoted.

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Dec 14, 2021

Background and more detail at MyIntervals/emogrifier#1129.

@raxbg
Copy link
Contributor

raxbg commented Sep 20, 2022

Hi, you don't need the quotes on the HTML side but you seem to need them in CSS.

Please take a look at this pen https://codepen.io/raxbg/pen/OJZgRVz

@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Sep 20, 2022

Hi, you don't need the quotes on the HTML side but you seem to need them in CSS.

Looks like you are right (neither Chrome nor Firefox apply the CSS rule without quotes), and thus the test referred to in MyIntervals/emogrifier#1129 was invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants