Skip to content

Add Rector #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Feb 3, 2024 · 2 comments
Closed

Add Rector #432

oliverklee opened this issue Feb 3, 2024 · 2 comments
Labels
enhancement
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Collaborator

oliverklee commented Feb 3, 2024 •
edited
Loading

This will help us do automatic refactorings.

Also add a configuration file and prevent it from getting shipped.
This was referenced Feb 3, 2024
Closed
Open
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this issue Jun 17, 2024
@ziegenberg
[TASK] Add rector to composer.json with a simple null-config
3d7febb 
Adding rector as a development dependency enables us to do automatic
refactorings. Initially this comes with a simple null-config, that does
not do much but run rector, so following the suggested integration path
of "taking it slow" [1].

Helps with MyIntervals#432

[1] https://getrector.com/documentation/integration-to-new-project

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg mentioned this issue Jun 17, 2024
Merged
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this issue Jun 17, 2024
@ziegenberg
[TASK] Add rector to composer.json with a simple null-config
bdc1b49 
Adding rector as a development dependency enables us to do automatic
refactorings. Initially this comes with a simple null-config, that does
not do much but run rector, so following the suggested integration path
of "taking it slow" [1].

Helps with MyIntervals#432

[1] https://getrector.com/documentation/integration-to-new-project

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
ziegenberg added a commit to ziegenberg/PHP-CSS-Parser that referenced this issue Jun 17, 2024
@ziegenberg
[TASK] Add rector to composer.json with a simple null-config
e1afb9d 
Adding rector as a development dependency enables us to do automatic
refactorings. Initially this comes with a simple null-config, that does
not do much but run rector, so following the suggested integration path
of "taking it slow" [1].

Helps with MyIntervals#432

[1] https://getrector.com/documentation/integration-to-new-project

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
oliverklee pushed a commit that referenced this issue Jun 17, 2024
@ziegenberg
[TASK] Add Rector to with a simple null-config to our toolchain (#546)
2b5d935 
Adding rector as a development dependency enables us to do automatic
refactorings. Initially this comes with a simple null-config, that does
not do much but run rector, so following the suggested integration path
of "taking it slow" [1].

Helps with #432

[1] https://getrector.com/documentation/integration-to-new-project

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
Copy link
Contributor

@oliverklee can this be considered done?

@oliverklee
Copy link
Collaborator Author

oliverklee commented Jun 17, 2024 •
edited
Loading

Yes. Thank you very much for driving this forward! 🙏 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

No branches or pull requests
2 participants
@oliverklee @ziegenberg