Skip to content

Add test for clamp() #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JakeQZ opened this issue Jun 26, 2024 · 0 comments · Fixed by #620
Closed

Add test for clamp() #619

JakeQZ opened this issue Jun 26, 2024 · 0 comments · Fixed by #620
Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Milestone
8.6.0 - Critical ...

Comments

@JakeQZ
Copy link
Collaborator

JakeQZ commented Jun 26, 2024

See #390 (comment).

The fix from #390 may mean that clamp() is now parsed correctly. Or there may be more work to do. Once a test is added, we'll know.
@JakeQZ JakeQZ added the testing PRs/issues adding additional tests only, or primarily testing-focused label Jun 26, 2024
@JakeQZ JakeQZ added this to the 8.6.0 - Critical Features milestone Jun 26, 2024
JakeQZ added a commit that referenced this issue Jun 26, 2024
@JakeQZ
[TASK] Test parsing arithmetic operators in clamp function
a3e54c3 
Closes #619.

The test passes, whereas without the change from #607, it does not.
@JakeQZ JakeQZ mentioned this issue Jun 26, 2024
Merged
oliverklee pushed a commit that referenced this issue Jun 27, 2024
@JakeQZ
[TASK] Test parsing arithmetic operators in clamp function (#620)
77fcdd4 
Closes #619.

The test passes, whereas without the change from #607, it does not.

Co-authored-by: Jake Hotson <jake.github@qzdesign.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Milestone
8.6.0 - Critical Features
Development

Successfully merging a pull request may close this issue.

[TASK] Test parsing arithmetic operators in clamp function MyIntervals/PHP-CSS-Parser
1 participant
@JakeQZ