Skip to content

Add a PHP-CS-Fixer rule to avoid deprecation warnings in PHP 8.4 #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Jul 1, 2024 · 1 comment · Fixed by #643
Closed

Add a PHP-CS-Fixer rule to avoid deprecation warnings in PHP 8.4 #634

oliverklee opened this issue Jul 1, 2024 · 1 comment · Fixed by #643
Assignees
@oliverklee
Milestone
9.0.0: Drop suppo...

Comments

@oliverklee
Copy link
Collaborator

https://cs.symfony.com/doc/rules/function_notation/nullable_type_declaration_for_default_null_value.html
@oliverklee
Copy link
Collaborator Author

https://review.typo3.org/c/Packages/TYPO3.CMS/+/85089

@oliverklee oliverklee self-assigned this Jul 4, 2024
oliverklee added a commit that referenced this issue Jul 4, 2024
@oliverklee
[TASK] Ensure PHP 8.4 compatibility for nullable parameters
223fed4 
Ensure that parameters that have a `null` default value also
have `null` as part of their type declarations.

Also ensure a uniform notation for nullable types.

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
@oliverklee oliverklee mentioned this issue Jul 4, 2024
Merged
oliverklee added a commit that referenced this issue Aug 26, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
a0b106a 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
oliverklee added a commit that referenced this issue Aug 26, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
81c6fab 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
@oliverklee oliverklee mentioned this issue Aug 26, 2024
Closed
oliverklee added a commit that referenced this issue Aug 26, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
c6c9f34 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
oliverklee added a commit that referenced this issue Aug 26, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
e421dd4 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
oliverklee added a commit that referenced this issue Aug 28, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
39a7c72 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
oliverklee added a commit that referenced this issue Sep 1, 2024
@oliverklee
[BUGFIX] Ensure PHP 8.4 compatibility for nullable parameters
f65d376 
Ensure that parameters that have a `null` default value also
have `null` as part of their type annotations.

Also remove native type declarations for nullable parameters
(as nullable parameters are not possible with some of the PHP
versions we currently support).

https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Fixes #634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging a pull request may close this issue.

[TASK] Ensure PHP 8.4 compatibility for nullable parameters MyIntervals/PHP-CSS-Parser
1 participant
@oliverklee