Skip to content

Make all properties of OutputFormat as @internal and to be made private in 9.0 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oliverklee opened this issue Feb 6, 2025 · 1 comment · Fixed by #886
Closed

Make all properties of OutputFormat as @internal and to be made private in 9.0 #881

oliverklee opened this issue Feb 6, 2025 · 1 comment · Fixed by #886
Assignees
@oliverklee
Milestone
8.8.0: Deprecate ...

Comments

@oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee added this to the 8.8.0 milestone Feb 6, 2025
@JakeQZ
Copy link
Collaborator

JakeQZ commented Feb 6, 2025

I've seen @deprecated used for this:

https://github.com/doctrine/instantiator/blob/1.5.x/src/Doctrine/Instantiator/Instantiator.php#L32

    /**
     * ...
     *
     * @deprecated This constant will be private in 2.0
     */

Don't know which is best practice.

@oliverklee oliverklee self-assigned this Feb 9, 2025
oliverklee added a commit that referenced this issue Feb 9, 2025
@oliverklee
[TASK] Make all non-private properties @internal
ca6ffc4 
This communicates clearly that the properties may be
removed, renamed or made `private` at any point, and that
they should not be accessed directly, but using the accessors
instead.

Also add a type annotation that was missing.

Fixes #881
@oliverklee oliverklee mentioned this issue Feb 9, 2025
Merged
@JakeQZ JakeQZ closed this as completed in f7914f8 Feb 9, 2025
oliverklee added a commit that referenced this issue Feb 9, 2025
@oliverklee
[TASK] Make all non-private properties @internal
a415135 
This communicates clearly that the properties may be
removed, renamed or made `private` at any point, and that
they should not be accessed directly, but using the accessors
instead.

Also add a type annotation that was missing.

Fixes #881

This is the V8.x backport of #886.
@oliverklee oliverklee mentioned this issue Feb 9, 2025
Merged
JakeQZ pushed a commit that referenced this issue Feb 9, 2025
@oliverklee
[TASK] Make all non-private properties @internal (#889)
2783dde 
This communicates clearly that the properties may be
removed, renamed or made `private` at any point, and that
they should not be accessed directly, but using the accessors
instead.

Also add a type annotation that was missing.

Fixes #881

This is the V8.x backport of #886.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
8.8.0: Deprecate and replace some API...
Development

Successfully merging a pull request may close this issue.

[TASK] Make all non-private properties @internal MyIntervals/PHP-CSS-Parser
2 participants
@oliverklee @JakeQZ