Use a `null` default value in `DeclarationBlock::parse()` instead of `false` #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

oliverklee opened this issue Feb 24, 2025 · 0 comments · Fixed by #988

Labels

cleanup

Milestone

9.0.0: Drop suppo...

Collaborator

oliverklee commented Feb 24, 2025

oliverklee added the cleanup label

oliverklee added this to the 9.0.0: Drop support for PHP < 7.2 and clean up things milestone

oliverklee mentioned this issue

[CLEANUP] Avoid Hungarian notation for string* #972

Merged

JakeQZ added a commit that referenced this issue


          [CLEANUP] Use null for unset value in DeclarationBlock::parse()

85e70b7

The variable is either a string or it isn't.
The best practice for when it isn't is for it to be `null` or `unset()`.

Using `false` for when it isn't can lead to type-safety issues.
Reference:
https://vulke.medium.com/when-should-variables-be-null-false-undefined-or-an-empty-string-in-php-4ebd73c7a954

Also use `===` in a comparison in the affected code.

Resolves #975.
Part of #976.

JakeQZ mentioned this issue

[CLEANUP] Use null for unset value in DeclarationBlock::parse() #988

Merged

oliverklee closed this as completed in #988

oliverklee closed this as completed in

6ff4aa5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment